linux-kernel - Re: [PATCH v3] pmdomain: Use str_enable_disable() and str_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVEkq_W99XuKA9KJW5Bm156ZBZowH2gmg2iY27y2fDFug@mail.gmail.com>
Date: Tue, 1 Jul 2025 11:35:26 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: shao.mingyin@....com.cn
Cc: geert+renesas@...der.be, changhuang.liang@...rfivetech.com, 
	magnus.damm@...il.com, heiko@...ech.de, alim.akhtar@...sung.com, 
	walker.chen@...rfivetech.com, sebastian.reichel@...labora.com, 
	detlev.casanova@...labora.com, finley.xiao@...k-chips.com, 
	shawn.lin@...k-chips.com, pgwipeout@...il.com, linux-pm@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, yang.yang29@....com.cn, 
	xu.xin16@....com.cn, yang.tao172@....com.cn, ye.xingchen@....com.cn
Subject: Re: [PATCH v3] pmdomain: Use str_enable_disable() and str_on_off() helpers

Hi Shao,

On Fri, 20 Jun 2025 at 10:09, <shao.mingyin@....com.cn> wrote:
> From: Shao Mingyin <shao.mingyin@....com.cn>
>
> Use str_enable_disable() and str_on_off() helper instead of open
> coding the same.
>
> Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn>
> Reviewed-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
> ---
> v3:
> preserve the original patch format to avoid whitespace-damaged
>  drivers/pmdomain/renesas/rcar-gen4-sysc.c    | 3 ++-
>  drivers/pmdomain/renesas/rcar-sysc.c         | 3 ++-
>  drivers/pmdomain/rockchip/pm-domains.c       | 3 ++-
>  drivers/pmdomain/samsung/exynos-pm-domains.c | 6 +++---
>  drivers/pmdomain/starfive/jh71xx-pmu.c       | 7 ++++---
>  5 files changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/pmdomain/renesas/rcar-gen4-sysc.c b/drivers/pmdomain/renesas/rcar-gen4-sysc.c
> index e001b5c25bed..c8aa7538e95f 100644
> --- a/drivers/pmdomain/renesas/rcar-gen4-sysc.c
> +++ b/drivers/pmdomain/renesas/rcar-gen4-sysc.c
> @@ -18,6 +18,7 @@
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
>  #include <linux/types.h>
> +#include <linux/string_choices.h>

Please insert new includes alphabetically, like in Krzysztof's original [1],
for which I already provided my Rb-tag.

[1] https://lore.kernel.org/all/CAMuHMdXJ57mATWW4AnBedn+D7TQ4PadkJ642daquFtAo=wZFrQ@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds