[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DB0MZCUM41RA.7Z6461I531VD@fairphone.com>
Date: Tue, 01 Jul 2025 12:12:07 +0200
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Krzysztof Kozlowski" <krzk@...nel.org>
Cc: "Bjorn Andersson" <andersson@...nel.org>, "Mathieu Poirier"
<mathieu.poirier@...aro.org>, "Rob Herring" <robh@...nel.org>, "Krzysztof
Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>,
"Manivannan Sadhasivam" <mani@...nel.org>,
<~postmarketos/upstreaming@...ts.sr.ht>, <phone-devel@...r.kernel.org>,
<linux-arm-msm@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas:
document SM7635 MPSS & WPSS
Hi Krzysztof,
On Tue Jul 1, 2025 at 10:12 AM CEST, Krzysztof Kozlowski wrote:
> On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote:
>> @@ -91,6 +93,7 @@ allOf:
>> properties:
>> compatible:
>> enum:
>> + - qcom,sm7635-mpss-pas
>> - qcom,sm8350-mpss-pas
>> - qcom,sm8450-mpss-pas
>> then:
>> @@ -142,6 +145,22 @@ allOf:
>> - const: cx
>> - const: mxc
>>
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,sm7635-wpss-pas
>
> Everything fits better sm6350 and no need for new if:then: entry, at
> least it looks like.
True, that seems to work fine as well. I can add it to the
qcom,sm6350-pas.yaml bindings instead of sm8350 in the next version.
To be honest, I don't quite understand what the concept behind the
different PAS bindings are, when an SoC should get a new .yaml file, and
when to add to an existing one.
Regards
Luca
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists