linux-kernel - Re: [PATCH net-next v2 0/9] net: Remove unused function parameters in skbuff.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250630181847.525a0ad6@kernel.org>
Date: Mon, 30 Jun 2025 18:18:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Michal Luczaj <mhal@...x.co>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima
 <kuniyu@...gle.com>, David Ahern <dsahern@...nel.org>, Boris Pismenny
 <borisp@...dia.com>, John Fastabend <john.fastabend@...il.com>, Ayush Sawal
 <ayush.sawal@...lsio.com>, Andrew Lunn <andrew+netdev@...n.ch>, Wenjia
 Zhang <wenjia@...ux.ibm.com>, Jan Karcher <jaka@...ux.ibm.com>, "D. Wythe"
 <alibuda@...ux.alibaba.com>, Tony Lu <tonylu@...ux.alibaba.com>, Wen Gu
 <guwen@...ux.alibaba.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-s390@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/9] net: Remove unused function parameters
 in skbuff.c

On Thu, 26 Jun 2025 10:33:33 +0200 Michal Luczaj wrote:
> Couple of cleanup patches to get rid of unused function parameters around
> skbuff.c, plus little things spotted along the way.
> 
> Offshoot of my question in [1], but way more contained. Found by adding
> "-Wunused-parameter -Wno-error" to KBUILD_CFLAGS and grepping for specific
> skbuff.c warnings.

I feel a little ambivalent about the removal of the flags arguments.
I understand that they are unused now, but theoretically the operation
as a whole has flags so it's not crazy to pass them along.. Dunno.