linux-kernel - RE: [PATCH] drm/dp: Clean up white space in drm_edp_backlight_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM3PPF208195D8D423BDB8FC477429FCA3BE340A@DM3PPF208195D8D.namprd11.prod.outlook.com>
Date: Wed, 2 Jul 2025 13:09:10 +0000
From: "Kandpal, Suraj" <suraj.kandpal@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>
CC: Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann
	<tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter
	<simona@...ll.ch>, "Nikula, Jani" <jani.nikula@...el.com>, "Deak, Imre"
	<imre.deak@...el.com>, "Murthy, Arun R" <arun.r.murthy@...el.com>, "Dmitry
 Baryshkov" <lumag@...nel.org>, Andy Yan <andy.yan@...k-chips.com>, "Dave
 Airlie" <airlied@...hat.com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] drm/dp: Clean up white space in
 drm_edp_backlight_probe_state()



> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@...aro.org>
> Sent: Wednesday, July 2, 2025 6:25 PM
> To: Kandpal, Suraj <suraj.kandpal@...el.com>; Maarten Lankhorst
> <maarten.lankhorst@...ux.intel.com>
> Cc: Maxime Ripard <mripard@...nel.org>; Thomas Zimmermann
> <tzimmermann@...e.de>; David Airlie <airlied@...il.com>; Simona Vetter
> <simona@...ll.ch>; Nikula, Jani <jani.nikula@...el.com>; Deak, Imre
> <imre.deak@...el.com>; Murthy, Arun R <arun.r.murthy@...el.com>; Dmitry
> Baryshkov <lumag@...nel.org>; Andy Yan <andy.yan@...k-chips.com>; Dave
> Airlie <airlied@...hat.com>; dri-devel@...ts.freedesktop.org; linux-
> kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: [PATCH] drm/dp: Clean up white space in
> drm_edp_backlight_probe_state()
> 
> This code needs to be indented one more tab.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@...el.com>

> ---
>  drivers/gpu/drm/display/drm_dp_helper.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c
> b/drivers/gpu/drm/display/drm_dp_helper.c
> index db7896c7edb8..1c3920297906 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -4245,14 +4245,14 @@ drm_edp_backlight_probe_state(struct
> drm_dp_aux *aux, struct drm_edp_backlight_i
>  					    "%s: Failed to read backlight level:
> %d\n",
>  					    aux->name, ret);
>  				return ret;
> -		}
> +			}
> 
> -		/*
> -		 * Incase luminance is set we want to send the value back in
> nits but since
> -		 * DP_EDP_PANEL_TARGET_LUMINANCE stores values in
> millinits we need to divide
> -		 * by 1000.
> -		 */
> -		return (buf[0] | buf[1] << 8 | buf[2] << 16) / 1000;
> +			/*
> +			 * Incase luminance is set we want to send the value
> back in nits but
> +			 * since DP_EDP_PANEL_TARGET_LUMINANCE stores
> values in millinits we
> +			 * need to divide by 1000.
> +			 */
> +			return (buf[0] | buf[1] << 8 | buf[2] << 16) / 1000;
>  		} else {
>  			ret = drm_dp_dpcd_read_data(aux,
> DP_EDP_BACKLIGHT_BRIGHTNESS_MSB,
>  						    buf, size);
> --
> 2.47.2