linux-kernel - Re: [PATCH v2 4/8] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175146290763.1131398.8272632937196214694.robh@kernel.org>
Date: Wed, 02 Jul 2025 08:28:30 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Albert Yang <yangzh0906@...ndersoft.com>
Cc: andersson@...nel.org, krzk@...nel.org, victor.shih@...esyslogic.com.tw, 
 will@...nel.org, quic_tdas@...cinc.com, nfraprado@...labora.com, 
 mani@...nel.org, ebiggers@...gle.com, geert+renesas@...der.be, 
 geert.uytterhoeven@...il.com, krzk+dt@...nel.org, conor+dt@...nel.org, 
 shanchun1218@...il.com, nm@...com, arnd@...db.de, 
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
 jonathan.cameron@...wei.com, bigfoot@...ssfun.cn, catalin.marinas@....com, 
 linux-kernel@...r.kernel.org, soc@...ts.linux.dev, gordon.ge@....ai, 
 kever.yang@...k-chips.com, ben.chuang@...esyslogic.com.tw, 
 bst-upstream@...ai.top, ulf.hansson@...aro.org, neil.armstrong@...aro.org, 
 linux-mmc@...r.kernel.org, adrian.hunter@...el.com
Subject: Re: [PATCH v2 4/8] dt-bindings: mmc: add binding for BST DWCMSHC
 SDHCI controller


On Wed, 02 Jul 2025 17:44:40 +0800, Albert Yang wrote:
> Add device tree binding documentation for the Black Sesame Technologies
> (BST) DWCMSHC SDHCI controller.
> 
> This binding describes the required and optional properties for the
> bst,dwcmshc-sdhci compatible controller, including register layout,
> interrupts, bus width, clock configuration, and other controller-specific
> features.
> 
> ---
> Changes for v2:
> - Simplified description, removed redundant paragraphs
> - Updated $schema to reference mmc-specific scheme
> - Corrected compatible to add soc name
> (bst,c1200-dwcmshc-sdhci)
> - Removed all redundant property descriptions
> - Dropped invalid mmc_crm_base/size properties, use reg for all address
> ranges
> - Cleaned up required properties to only essential entries
> - Standardized example DTS format, fixed reg syntax and property
> ordering
> - Removed additionalProperties: true
> 
> Signed-off-by: Ge Gordon <gordon.ge@....ai>
> Signed-off-by: Albert Yang <yangzh0906@...ndersoft.com>
> ---
>  .../bindings/mmc/bst,dwcmshc-sdhci.yaml       | 67 +++++++++++++++++++
>  1 file changed, 67 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.example.dtb: mmc@...00000 (bst,c1200-dwcmshc-sdhci): reg: [[0, 572522496], [0, 4096], [0, 587227136], [0, 4096]] is too long
	from schema $id: http://devicetree.org/schemas/mmc/bst,dwcmshc-sdhci.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250702094444.3523973-5-yangzh0906@thundersoft.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.