linux-kernel - [PATCH v5 1/3] i2c: tegra: Fix reset error handling with ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250702133450.64257-1-akhilrajeev@nvidia.com>
Date: Wed, 2 Jul 2025 19:04:47 +0530
From: Akhil R <akhilrajeev@...dia.com>
To: <andriy.shevchenko@...ux.intel.com>, <andi.shyti@...nel.org>,
	<digetx@...il.com>, <jonathanh@...dia.com>, <linux-i2c@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
	<p.zabel@...gutronix.de>, <thierry.reding@...il.com>
CC: <akhilrajeev@...dia.com>, <conor+dt@...nel.org>,
	<devicetree@...r.kernel.org>, <krzk+dt@...nel.org>, <ldewangan@...dia.com>,
	<robh@...nel.org>
Subject: [PATCH v5 1/3] i2c: tegra: Fix reset error handling with ACPI

The acpi_evaluate_object() returns an ACPI error code and not the
Linux one. For the some platforms the error will have positive code
which may be interpreted incorrectly. Use ACPI_FAILURE() to determine
the failure and return the error. Also move the reset to a separate
function to handle this better.

Fixes: bd2fdedbf2ba ("i2c: tegra: Add the ACPI support")
Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Signed-off-by: Akhil R <akhilrajeev@...dia.com>
---
New patch suggested in v4.

 drivers/i2c/busses/i2c-tegra.c | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 049b4d154c23..6f3d770c5a67 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -604,10 +604,25 @@ static int tegra_i2c_wait_for_config_load(struct tegra_i2c_dev *i2c_dev)
 	return 0;
 }
 
+static int tegra_i2c_reset(struct tegra_i2c_dev *i2c_dev)
+{
+	acpi_handle handle = ACPI_HANDLE(i2c_dev->dev);
+	int err;
+
+	if (handle) {
+		err = acpi_evaluate_object(handle, "_RST", NULL, NULL);
+		if (ACPI_FAILURE(err))
+			return -EIO;
+
+		return 0;
+	}
+
+	return reset_control_reset(i2c_dev->rst);
+}
+
 static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev)
 {
 	u32 val, clk_divisor, clk_multiplier, tsu_thd, tlow, thigh, non_hs_mode;
-	acpi_handle handle = ACPI_HANDLE(i2c_dev->dev);
 	struct i2c_timings *t = &i2c_dev->timings;
 	int err;
 
@@ -619,11 +634,7 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev)
 	 * emit a noisy warning on error, which won't stay unnoticed and
 	 * won't hose machine entirely.
 	 */
-	if (handle)
-		err = acpi_evaluate_object(handle, "_RST", NULL, NULL);
-	else
-		err = reset_control_reset(i2c_dev->rst);
-
+	err = tegra_i2c_reset(i2c_dev);
 	WARN_ON_ONCE(err);
 
 	if (IS_DVC(i2c_dev))
-- 
2.49.0