linux-kernel - Re: [PATCH v2 7/8] auxdisplay: Add Titanmec TM16xx 7-segment display controllers driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <668a149e-f39f-45dc-8c55-d914df116b47@kernel.org>
Date: Wed, 2 Jul 2025 17:05:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: ojeda@...nel.org, Jean-François Lessard
 <jefflessard3@...il.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Geert Uytterhoeven
 <geert@...ux-m68k.org>, devicetree@...r.kernel.org,
 linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
 Andreas Färber <afaerber@...e.de>,
 Boris Gjenero <boris.gjenero@...il.com>,
 Christian Hewitt <christianshewitt@...il.com>,
 Heiner Kallweit <hkallweit1@...il.com>,
 Paolo Sabatino <paolo.sabatino@...il.com>
Subject: Re: [PATCH v2 7/8] auxdisplay: Add Titanmec TM16xx 7-segment display
 controllers driver

On 30/06/2025 16:17, Andy Shevchenko wrote:
> On Mon, Jun 30, 2025 at 01:39:25PM +0200, Krzysztof Kozlowski wrote:
>> On 30/06/2025 11:54, Andy Shevchenko wrote:
>>> On Mon, Jun 30, 2025 at 11:27:21AM +0200, Krzysztof Kozlowski wrote:
>>>> On 30/06/2025 09:27, Andy Shevchenko wrote:
>>>>> On Mon, Jun 30, 2025 at 08:12:16AM +0200, Krzysztof Kozlowski wrote:
>>>>>> On 29/06/2025 15:18, Jean-François Lessard wrote:
> 
> ...
> 
>>>>>>> +	display->leds =
>>>>>>> +		devm_kcalloc(dev, display->num_leds, sizeof(*display->leds), GFP_KERNEL);
>>>>>>
>>>>>> Wrong wrapping. Use kernel style, not clang style.
>>>>>>
>>>>>>
>>>>>>> +	if (!display->leds)
>>>>>>> +		return -ENOMEM;
>>>>>
>>>>> Just wondering how .clang-format is official? Note some of the maintainers even
>>>>
>>>> First time I hear above clang style is preferred. Where is it expected?
>>>
>>> Documented here:
>>> https://www.kernel.org/doc/html/latest/process/coding-style.html#you-ve-made-a-mess-of-it
>>
>> I mean, which maintainers prefer such style of wrapping. Above I know,
>> but it does not solve the discussion we have here - above line wrapping
>> preferred by clang and opposite to most of the kernel code.
> 
> IIRC Dan Williams (as you might have deduced already from the links).
BTW, if that's your preference, then obviously it is perfectly fine.
It's your subsystem.


Best regards,
Krzysztof