linux-kernel - Re: [PATCH v5 3/3] i2c: tegra: Remove dma_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGVPKi1PZfnvv1s7@smile.fi.intel.com>
Date: Wed, 2 Jul 2025 18:24:26 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Akhil R <akhilrajeev@...dia.com>
Cc: andi.shyti@...nel.org, digetx@...il.com, jonathanh@...dia.com,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-tegra@...r.kernel.org, p.zabel@...gutronix.de,
	thierry.reding@...il.com, conor+dt@...nel.org,
	devicetree@...r.kernel.org, krzk+dt@...nel.org,
	ldewangan@...dia.com, robh@...nel.org,
	Robin Murphy <robin.murphy@....com>,
	Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH v5 3/3] i2c: tegra: Remove dma_sync_*() calls

On Wed, Jul 02, 2025 at 07:04:49PM +0530, Akhil R wrote:
> Calling dma_sync_*() on a buffer from dma_alloc_coherent() is pointless.
> The driver should not be doing its own bounce-buffering if the buffer is
> allocated through dma_alloc_coherent()

Missing period at the end of the sentence.

Code wise LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko