linux-kernel - Re: [PATCH 3/5] clk: sunxi-ng: v3s: Fix CSI1 MCLK clock name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a9b51f36da2500604f8d1099b0765f1e3764f10.camel@icenowy.me>
Date: Wed, 02 Jul 2025 11:10:02 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Paul Kocialkowski <paulk@...-base.io>, linux-media@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-clk@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linux-gpio@...r.kernel.org
Cc: Yong Deng <yong.deng@...ewell.com>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec
 <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, Michael
 Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
 Maxime Ripard <mripard@...nel.org>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann
 <tzimmermann@...e.de>,  David Airlie <airlied@...il.com>, Simona Vetter
 <simona@...ll.ch>, Linus Walleij <linus.walleij@...aro.org>,  Icenowy Zheng
 <icenowy@...c.xyz>, Andre Przywara <andre.przywara@....com>
Subject: Re: [PATCH 3/5] clk: sunxi-ng: v3s: Fix CSI1 MCLK clock name

在 2025-07-01星期二的 22:11 +0200，Paul Kocialkowski写道：
> The CSI1 MCLK clock is reported as "csi-mclk" while it is specific to
> CSI1 as the name of the definition indicates. Fix it in the driver.
> 
> Fixes: d0f11d14b0bc ("clk: sunxi-ng: add support for V3s CCU")
> Signed-off-by: Paul Kocialkowski <paulk@...-base.io>
> ---
>  drivers/clk/sunxi-ng/ccu-sun8i-v3s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c
> b/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c
> index d12791b31a9d..86d933d1ac72 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c
> @@ -366,7 +366,7 @@ static const char * const csi_sclk_parents[] = {
> "pll-video", "pll-isp" };
>  static SUNXI_CCU_M_WITH_MUX_GATE(csi_sclk_clk, "csi-sclk",
> csi_sclk_parents,
>                                  0x134, 16, 4, 24, 3, BIT(31), 0);
>  
> -static SUNXI_CCU_M_WITH_MUX_GATE(csi1_mclk_clk, "csi-mclk",
> csi_mclk_parents,
> +static SUNXI_CCU_M_WITH_MUX_GATE(csi1_mclk_clk, "csi1-mclk",
> csi_mclk_parents,
>                                  0x134, 0, 5, 8, 3, BIT(15), 0);

Yes, there exists csi0-mclk.

Reviewed-By: Icenowy Zheng <uwu@...nowy.me>

>  
>  static SUNXI_CCU_M_WITH_GATE(ve_clk, "ve", "pll-ve",