[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aGVmZ_VQiFfYCSaS@google.com>
Date: Wed, 2 Jul 2025 10:03:35 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Thomas Richter <tmricht@...ux.ibm.com>
Cc: Ian Rogers <irogers@...gle.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
agordeev@...ux.ibm.com, gor@...ux.ibm.com, hca@...ux.ibm.com
Subject: Re: [Ping][PATCH] perf list: Add IBM z17 event descriptions
Hello,
On Wed, Jul 02, 2025 at 10:57:58AM +0200, Thomas Richter wrote:
> On 6/27/25 18:55, Ian Rogers wrote:
> > On Fri, Jun 27, 2025 at 1:13 AM Thomas Richter <tmricht@...ux.ibm.com> wrote:
> >>
> >> On 6/24/25 08:35, Thomas Richter wrote:
> >>
> >> Gently Ping
> >>
> >> Ian, I have responded to your comments some days ago.
> >
> > Thanks Thomas, minor nit in your explanation the events must exist as
> > they are in json, but the json events are only exposed if the PMU is
> > present, so the has_event is more of a has_pmu test. Maybe we should
> > add a function like this to the metrics to make this kind of case
> > clearer. Maybe `perf list` should test the events of a metric and hide
> > metrics when the events aren't available to avoid the have_event
> > logic. I'm a bit uncomfortable with that as the events may not be
> > available because of permission issues, but it'd still be useful to
> > know the metrics are around. Anyway I'm digressing.
> >
> > Reviewed-by: Ian Rogers <irogers@...gle.com>
> >
> > Thanks,
> > Ian
> >
>
> Arnaldo, Namhyung,
>
> with Ian Rogers Reviewed-by: approval, it is possible to
> accept this patch soon, so it will land in the next merge-window.
>
> That will give me an commit-id which I need for my addon work.
>
> Thanks a lot for your help.
Sorry about the delay, I'll process this soon.
Thanks,
Namhyung
Powered by blists - more mailing lists