linux-kernel - Re: [PATCH net] net: atm: Fix incorrect net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ebd4e0b.7b84.197c93c74b1.Coremail.linma@zju.edu.cn>
Date: Wed, 2 Jul 2025 11:44:31 +0800 (GMT+08:00)
From: "Lin Ma" <linma@....edu.cn>
To: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, mingo@...nel.org,
	tglx@...utronix.de, pwn9uin@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: atm: Fix incorrect net_device lec check

Hello there,

Moreover, there is another similar bug found via variant analysis

```
// net/appletalk/ddp.c
static int handle_ip_over_ddp(struct sk_buff *skb)
{
    struct net_device *dev = __dev_get_by_name(&init_net, "ipddp0");
    struct net_device_stats *stats;
    ...
```

The code believes that __dev_get_by_name() must return device created
in ipddp_init() function, ignoring the fact that a malicious user could
hijack the interface name.

This bug is "fixed" in upstream by
commit 85605fb694f0 ("appletalk: remove special handling code for ipddp").
However, the stable version, like v5.15.186, still contains it.

Shall I send another patch? Or should the stable branch employ the existing
commits?

Regards
Lin