linux-kernel - Re: [PATCH v2 3/3] nvme: prevent ioq creation for discovery controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN2PR04MB68626BDAC087B4CC8CC1A1A9BC40A@MN2PR04MB6862.namprd04.prod.outlook.com>
Date: Wed, 2 Jul 2025 18:09:30 +0000
From: Kamaljit Singh <Kamaljit.Singh1@....com>
To: Damien Le Moal <dlemoal@...nel.org>, "kbusch@...nel.org"
	<kbusch@...nel.org>, "axboe@...nel.dk" <axboe@...nel.dk>, hch <hch@....de>,
	"sagi@...mberg.me" <sagi@...mberg.me>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "cassel@...nel.org" <cassel@...nel.org>
Subject: Re: [PATCH v2 3/3] nvme: prevent ioq creation for discovery
 controllers

Hi Damien,
 
On 7/1/25 19:18, Damien Le Moal wrote:
>>  /*
>> - * An admin controller has one admin queue, but no I/O queues.
>> + * An admin or discovery controller has one admin queue, but no I/O queues.
>>   * Override queue_count so it only creates an admin queue.
>>   */
>>  void nvme_override_prohibited_io_queues(struct nvme_ctrl *ctrl)
>>  {
>> -     if (nvme_admin_ctrl(ctrl))
>> +     if (nvme_admin_ctrl(ctrl) || nvme_discovery_ctrl(ctrl))
>>               ctrl->queue_count = 1;
>>  }
>>  EXPORT_SYMBOL_GPL(nvme_override_prohibited_io_queues);
>
>Repeating comment on patch 1. Can't we do this in nvme_init_subsystem() or may
>be better, in nvme_set_queue_count() or nvme_init_ctrl_finish() ?
nvme_set_queue_count() won’t even be called in this case, as its only used to
configure IO queues, which are not being configured for an admin controller.
 
If we move nvme_override_prohibited_io_queues() up the stack into either of your
suggested core.c functions, it will affect apple & fc drivers, which I don’t have any
means of testing. Any suggestions?

Thanks,
Kamaljit