linux-kernel - Re: [PATCH v1] perf genelf: Fix NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGWF0Czs_7moo8uO@google.com>
Date: Wed, 2 Jul 2025 12:17:36 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Yuzhuo Jing <yuzhuo@...gle.com>, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf genelf: Fix NO_LIBDW=1 build

On Wed, Jul 02, 2025 at 10:54:02AM -0700, Ian Rogers wrote:
> With NO_LIBDW=1 a new unused-parameter warning/error has appeared:
> ```
> util/genelf.c: In function ‘jit_write_elf’:
> util/genelf.c:163:32: error: unused parameter ‘load_addr’ [-Werror=unused-parameter]
>   163 | jit_write_elf(int fd, uint64_t load_addr, const char *sym,
> ```

Thanks for the fix.

And I found there's no entry for NO_LIBDW=1 in the build-test.
Can you please add one?

Thanks,
Namhyung

> 
> Fixes: e3f612c1d8f3 ("perf genelf: Remove libcrypto dependency and use built-in sha1()")
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/util/genelf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
> index fcf86a27f69e..591548b10e34 100644
> --- a/tools/perf/util/genelf.c
> +++ b/tools/perf/util/genelf.c
> @@ -160,7 +160,7 @@ jit_add_eh_frame_info(Elf *e, void* unwinding, uint64_t unwinding_header_size,
>   * csize: the code size in bytes
>   */
>  int
> -jit_write_elf(int fd, uint64_t load_addr, const char *sym,
> +jit_write_elf(int fd, uint64_t load_addr __maybe_unused, const char *sym,
>  	      const void *code, int csize,
>  	      void *debug __maybe_unused, int nr_debug_entries __maybe_unused,
>  	      void *unwinding, uint64_t unwinding_header_size, uint64_t unwinding_size)
> -- 
> 2.50.0.727.gbf7dc18ff4-goog
>