linux-kernel - Re: [PATCH v8 01/10] arm64: Add config for Microchip SoC platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ea353170-6e03-4231-afc2-3dc45253931d@app.fastmail.com>
Date: Wed, 02 Jul 2025 21:57:10 +0200
From: "Arnd Bergmann" <arnd@...nel.org>
To: "Robert Marko" <robert.marko@...tura.hr>,
 "Russell King" <linux@...linux.org.uk>,
 "Nicolas Ferre" <nicolas.ferre@...rochip.com>,
 "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
 "Claudiu Beznea" <claudiu.beznea@...on.dev>,
 "Catalin Marinas" <catalin.marinas@....com>, "Will Deacon" <will@...nel.org>,
 "Olivia Mackall" <olivia@...enic.com>,
 "Herbert Xu" <herbert@...dor.apana.org.au>,
 "David S . Miller" <davem@...emloft.net>, "Vinod Koul" <vkoul@...nel.org>,
 "Andi Shyti" <andi.shyti@...nel.org>, "Lee Jones" <lee@...nel.org>,
 "Mark Brown" <broonie@...nel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Jiri Slaby" <jirislaby@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
 dmaengine@...r.kernel.org, linux-i2c@...r.kernel.org,
 linux-spi@...r.kernel.org, linux-serial@...r.kernel.org,
 "Oleksij Rempel" <o.rempel@...gutronix.de>,
 "Daniel Machon" <daniel.machon@...rochip.com>
Cc: luka.perkov@...tura.hr
Subject: Re: [PATCH v8 01/10] arm64: Add config for Microchip SoC platforms

On Wed, Jul 2, 2025, at 20:35, Robert Marko wrote:
> Currently, Microchip SparX-5 SoC is supported and it has its own symbol.
>
> However, this means that new Microchip platforms that share drivers need
> to constantly keep updating depends on various drivers.
>
> So, to try and reduce this lets add ARCH_MICROCHIP symbol that drivers
> could instead depend on.

Thanks for updating the series to my suggestion!

> @@ -174,6 +160,27 @@ config ARCH_MESON
>  	  This enables support for the arm64 based Amlogic SoCs
>  	  such as the s905, S905X/D, S912, A113X/D or S905X/D2
> 
> +menuconfig ARCH_MICROCHIP
> +	bool "Microchip SoC support"
> +
> +if ARCH_MICROCHIP
> +
> +config ARCH_SPARX5
> +	bool "Microchip Sparx5 SoC family"

This part is the one bit I'm not sure about: The user-visible
arm64 CONFIG_ARCH_* symbols are usually a little higher-level,
so I don't think we want both ARCH_MICROCHIP /and/ ARCH_SPARX5
here, or more generally speaking any of the nested ARCH_*
symbols.

This version of your patch is going to be slightly annoying
to existing sparx5 users because updating an old .config
breaks when ARCH_MICROCHIP is not enabled.

The two options that I would prefer here are 

a) make ARCH_SPARX5 a hidden symbol in order to keep the
   series bisectable, remove it entirely once all references
   are moved over to ARCH_MICROCHIP

b) Make ARCH_MICROCHIP a hidden symbol that is selected by
   ARCH_SPARX5 but keep the menu unchanged.

Let's see what the sparx5 and at91 maintainers think about
these options.

The other patches all look fine to me.

     Arnd