linux-kernel - Re: [PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for new RP configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <225ea9f2-dce7-498c-a2a4-5b40471b8e2a@kernel.org>
Date: Wed, 2 Jul 2025 22:20:52 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Manikandan Karunakaran Pillai <mpillai@...ence.com>,
 Hans Zhang <hans.zhang@...tech.com>
Cc: "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
 "lpieralisi@...nel.org" <lpieralisi@...nel.org>, "kw@...ux.com"
 <kw@...ux.com>, "mani@...nel.org" <mani@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>,
 "kwilczynski@...nel.org" <kwilczynski@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "fugang.duan@...tech.com" <fugang.duan@...tech.com>,
 "guoyin.chen@...tech.com" <guoyin.chen@...tech.com>,
 "peter.chen@...tech.com" <peter.chen@...tech.com>,
 "cix-kernel-upstream@...tech.com" <cix-kernel-upstream@...tech.com>,
 "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for
 new RP configuration

On 01/07/2025 13:56, Manikandan Karunakaran Pillai wrote:
> 
>>>> On 2025/6/30 15:30, Krzysztof Kozlowski wrote:
>>>>> EXTERNAL EMAIL
>>>>>
>>>>> On Mon, Jun 30, 2025 at 12:15:48PM +0800, hans.zhang@...tech.com
>> wrote:
>>>>>> From: Manikandan K Pillai <mpillai@...ence.com>
>>>>>>
>>>>>> Document the compatible property for HPA (High Performance
>>>> Architecture)
>>>>>> PCIe controller RP configuration.
>>>>>
>>>>> I don't see Conor's comment addressed:
>>>>>
>>>>> https://urldefense.com/v3/__https://lore.kernel.org/linux-
>>>> devicetree/20250424-elm-magma-
>>>> b791798477ab@...d/__;!!EHscmS1ygiU1lA!Bo-
>>>>
>> ayMVqCWXSbSgFpsBZzgk1ADft8pqRQbuOeAhIuAjz0zI015s4dmzxgaWKycqKMn
>>>> 1cejS8kKZvjF5xDAse$
>>>>>
>>>>> You cannot just send someone's work and bypassing the review feedback.
>>>
>>> I thought the comment was implicitly addressed when the device drivers
>> were separated out based on other review comments in this patch.
>>> To make it more clear, in the next patch I will add the following description
>> for the dt-binding patch
>>>
>>> "The High performance architecture is different from legacy architecture
>> controller in design of register banks,
>>> register definitions, hardware sequences of initialization and is considered as
>> a different device due to the
>>> large number of changes required in the device driver and hence adding a
>> new compatible."
>> That's still vague. Anyway this does not address other concern that the
>> generic compatible is discouraged and we expect specific compatibles. We
>> already said that and what? You send the same patch.
>>
>> So no, don't send the same patch.
> 
> 
> Hi Kryzsztof,
> 
> Are you suggesting to create new file for both RC and EP for HPA host like:
> cdns,cdns-pcie-hpa-host.yaml
> cdns,cdns-pcie-hpa-ep.yaml
> And during the commit log, explain why you need to create a new file for HPA, and not use the legacy one.

No, there was no such suggestions in any previous or current
discussions. IIRC, this was simply rejected previously. I consider this
rejected still, with the same arguments: you should use specific SoC
compatibles. The generic compatible alone is rather legacy approach and
we have been commenting on this sooooo many times.



Best regards,
Krzysztof