linux-kernel - Re: [PATCH v2] arm64: dts: renesas: Add CN15 eMMC and SD overlays for RZ/V2H and RZ/V2N EVKs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8snbBAeBP3+sz8R96A6Agdg33qp00GkffqB8DqDpzBXLg@mail.gmail.com>
Date: Wed, 2 Jul 2025 21:22:43 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2] arm64: dts: renesas: Add CN15 eMMC and SD overlays for
 RZ/V2H and RZ/V2N EVKs

Hi Geert,

Thank you for the review.

On Wed, Jul 2, 2025 at 2:19 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Fri, 27 Jun 2025 at 21:37, Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Introduce device tree overlays for supporting the eMMC (RTK0EF0186B02000BJ)
> > and microSD (RTK0EF0186B01000BJ) sub-boards connected via the CN15
> > connector on the RZ/V2H and RZ/V2N evaluation kits.
> >
> > These overlays enable SDHI0 with appropriate pin control settings, power
> > regulators, and GPIO handling. Both sub-boards are supported using shared
> > overlay files that can be applied to either EVK due to their identical
> > connector layout and interface support.
> >
> > To support this, new DT overlay files are added:
> > - `rzv2-evk-cn15-emmc.dtso` for eMMC
> > - `rzv2-evk-cn15-sd.dtso` for microSD
> >
> > Additionally, the base DTS files for both EVKs are updated to include a
> > fixed 1.8V regulator (`reg_1p8v`) needed by the eMMC sub-board and
> > potential future use cases such as HDMI output.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> > v1->v2:
> > - Dropped patch 2/3 from previous series as that has been merged.
> > - Dropped adding alias in base DTS instead added in overlay.
> > - Switched to using single overlay files for both RZ/V2H and RZ/V2N EVKs
> >   instead of separate overlays for each EVK.
> > - Used RZG2L_GPIO and RZG2L_PORT_PINMUX to avoid using SoC specific
> >   macros.
>
> Thanks for the update!
>
> > --- a/arch/arm64/boot/dts/renesas/Makefile
> > +++ b/arch/arm64/boot/dts/renesas/Makefile
> > @@ -161,8 +161,16 @@ r9a09g047e57-smarc-cru-csi-ov5645-dtbs := r9a09g047e57-smarc.dtb r9a09g047e57-sm
> >  dtb-$(CONFIG_ARCH_R9A09G047) += r9a09g047e57-smarc-cru-csi-ov5645.dtb
> >
> >  dtb-$(CONFIG_ARCH_R9A09G056) += r9a09g056n48-rzv2n-evk.dtb
> > +dtb-$(CONFIG_ARCH_R9A09G056) += rzv2-evk-cn15-emmc.dtbo
> > +r9a09g056n48-rzv2-evk-cn15-emmc.dts := r9a09g056n48-rzv2n-evk.dtb rzv2-evk-cn15-emmc.dtbo
>
> .dts?
>
Ouch.

> I take it you meant:
>
>     +r9a09g056n48-rzv2n-evk-cn15-emmc-dtbs :=
> r9a09g056n48-rzv2n-evk.dtb rzv2-evk-cn15-emmc.dtbo
>     +dtb-$(CONFIG_ARCH_R9A09G056) += r9a09g056n48-rzv2n-evk-cn15-emmc.dtb
>
> > +dtb-$(CONFIG_ARCH_R9A09G056) += rzv2-evk-cn15-sd.dtbo
> > +r9a09g056n48-rzv2-evk-cn15-sd.dts := r9a09g056n48-rzv2n-evk.dtb rzv2-evk-cn15-sd.dtbo
>
>     +r9a09g056n48-rzv2n-evk-cn15-sd-dtbs := r9a09g056n48-rzv2n-evk.dtb
> rzv2-evk-cn15-sd.dtbo
>     +dtb-$(CONFIG_ARCH_R9A09G056) += r9a09g056n48-rzv2n-evk-cn15-sd.dtb
>
> >  dtb-$(CONFIG_ARCH_R9A09G057) += r9a09g057h44-rzv2h-evk.dtb
> > +dtb-$(CONFIG_ARCH_R9A09G057) += rzv2-evk-cn15-emmc.dtbo
> > +r9a09g057h44-rzv2-evk-cn15-emmc.dts := r9a09g057h44-rzv2h-evk.dtb rzv2-evk-cn15-emmc.dtbo
>
>     +r9a09g057h44-rzv2h-evk-cn15-emmc-dtbs :=
> r9a09g057h44-rzv2h-evk.dtb rzv2-evk-cn15-emmc.dtbo
>     +dtb-$(CONFIG_ARCH_R9A09G057) += r9a09g057h44-rzv2h-evk-cn15-emmc.dtb
>
> > +dtb-$(CONFIG_ARCH_R9A09G057) += rzv2-evk-cn15-sd.dtbo
> > +r9a09g057h44-rzv2-evk-cn15-sd.dts := r9a09g057h44-rzv2h-evk.dtb rzv2-evk-cn15-sd.dtbo
>
>     +r9a09g057h44-rzv2h-evk-cn15-sd-dtbs := r9a09g057h44-rzv2h-evk.dtb
> rzv2-evk-cn15-sd.dtbo
>     +dtb-$(CONFIG_ARCH_R9A09G057) += r9a09g057h44-rzv2h-evk-cn15-sd.dtb
>
> >  dtb-$(CONFIG_ARCH_R9A09G057) += r9a09g057h48-kakip.dtb
> >
> >  dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> i.e. will queue in renesas-devel for v6.17, with the above fixed.
>
Thank you for taking care of it.

Cheers,
Prabhakar