[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <04a0d550-3fb4-4cf9-8adf-4ed54e3af7ba@kernel.org>
Date: Wed, 2 Jul 2025 22:30:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jayesh Choudhary <j-choudhary@...com>, nm@...com, vigneshr@...com,
devicetree@...r.kernel.org
Cc: kristo@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, s-vadapalli@...com, rogerq@...nel.org, afd@...com,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Make the "scm_conf"
node a "simple-bus"
On 01/07/2025 12:23, Jayesh Choudhary wrote:
> Hello Krzysztof,
>
> On 04/06/25 15:18, Jayesh Choudhary wrote:
>> Hello Krzysztof,
>>
>> On 03/06/25 16:32, Krzysztof Kozlowski wrote:
>>> On 03/06/2025 11:56, Jayesh Choudhary wrote:
>>>> The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
>>>> child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
>>>> "scm_conf" node to "simple-bus".
>>>> Also remove "reg" property as it is not needed by "simple-bus".
>>>
>>> This (possibly) affects all other users of DTS which were expecting this
>>> ABI. It's not only about forward-compatibility, but other projects.
>>>
>>> Maybe this doe snot matter for you, so explain that in commit msg and
>>> provide rationale why you are affecting other users.
>>>
>>>
>>
>> This should not affect other users of DTS. J784S4 already has this
>> change and it serves as a validation that DT nodes are compatible
>> with other projects (for example uboot driver handles it).
>> Other SoCs are being modified with taking J784S4 as a working reference.
>>
>> Considering this, do I still need to add something? Or is it okay
>> since I am not exactly affecting other projects?
>> Should I add something along the lines of "similar to j784s4...."?
>>
>
> Gentle ping on the above comment.
>
> I have checked other projects like Barebox. That supports TI K3 SoC
> but only AM62x and AM62L. Nothing in this series affects it.
Your answer is really not sufficient, just something to reply so I will
bug off, so I decided to ignore it.
This affects other projects - it is clearly visible in the diff. You
removed a compatible and you cannot do that.
Best regards,
Krzysztof
Powered by blists - more mailing lists