linux-kernel - Re: [PATCH net-next 0/6] eth: fbnic: Add firmware logging support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44ca3f26-fe6d-4758-ae4f-a22be7599b25@intel.com>
Date: Wed, 2 Jul 2025 13:45:59 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Lee Trager <lee@...ger.us>, Alexander Duyck <alexanderduyck@...com>,
	"Jakub Kicinski" <kuba@...nel.org>, <kernel-team@...a.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Kees Cook
	<kees@...nel.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, "Sanman
 Pradhan" <sanman.p211993@...il.com>, Mohsin Bashir <mohsin.bashr@...il.com>,
	Su Hui <suhui@...china.com>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Simon Horman <horms@...nel.org>, Kalesh AP
	<kalesh-anakkur.purayil@...adcom.com>
CC: Andrew Lunn <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH net-next 0/6] eth: fbnic: Add firmware logging support



On 7/2/2025 12:12 PM, Lee Trager wrote:
> Firmware running on fbnic generates device logs. These logs contain useful
> information about the device which may or may not be related to the host.
> Logs are stored in a ring buffer and accessible through DebugFS.
> 
> Lee Trager (6):
>   eth: fbnic: Fix incorrect minimum firmware version
>   eth: fbnic: Use FIELD_PREP to generate minimum firmware version
>   eth: fbnic: Create ring buffer for firmware logs
>   eth: fbnic: Add mailbox support for firmware logs
>   eth: fbnic: Enable firmware logging
>   eth: fbnic: Create fw_log file in DebugFS
> 

Everything looked straight forward to me.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  drivers/net/ethernet/meta/fbnic/Makefile      |   1 +
>  drivers/net/ethernet/meta/fbnic/fbnic.h       |   3 +
>  drivers/net/ethernet/meta/fbnic/fbnic_csr.h   |  27 ++-
>  .../net/ethernet/meta/fbnic/fbnic_debugfs.c   |  29 +++
>  drivers/net/ethernet/meta/fbnic/fbnic_fw.c    | 179 +++++++++++++++++-
>  drivers/net/ethernet/meta/fbnic/fbnic_fw.h    |  36 ++++
>  .../net/ethernet/meta/fbnic/fbnic_fw_log.c    | 123 ++++++++++++
>  .../net/ethernet/meta/fbnic/fbnic_fw_log.h    |  45 +++++
>  drivers/net/ethernet/meta/fbnic/fbnic_pci.c   |  21 ++
>  9 files changed, 451 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/net/ethernet/meta/fbnic/fbnic_fw_log.c
>  create mode 100644 drivers/net/ethernet/meta/fbnic/fbnic_fw_log.h
> 
> --
> 2.47.1



Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)