linux-kernel - Re: [PATCH v5 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGWooERKYBmoCBM9@intel.com>
Date: Wed, 2 Jul 2025 17:46:35 -0400
From: Rodrigo Vivi <rodrigo.vivi@...el.com>
To: Badal Nilawar <badal.nilawar@...el.com>
CC: <intel-xe@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, <anshuman.gupta@...el.com>,
	<alexander.usyskin@...el.com>, <gregkh@...uxfoundation.org>,
	<daniele.ceraolospurio@...el.com>
Subject: Re: [PATCH v5 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw
 during system resume

On Wed, Jul 02, 2025 at 10:22:13PM +0530, Badal Nilawar wrote:
> Reload late binding fw during resume from system suspend
> 
> v2:
>   - Unconditionally reload late binding fw (Rodrigo)
>   - Flush worker during system suspend
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
> Signed-off-by: Badal Nilawar <badal.nilawar@...el.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@...el.com>

> ---
>  drivers/gpu/drm/xe/xe_pm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 734fe259600e..13afaf97d831 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -127,6 +127,8 @@ int xe_pm_suspend(struct xe_device *xe)
>  	if (err)
>  		goto err;
>  
> +	xe_late_bind_wait_for_worker_completion(&xe->late_bind);
> +
>  	for_each_gt(gt, xe, id)
>  		xe_gt_suspend_prepare(gt);
>  
> @@ -205,6 +207,8 @@ int xe_pm_resume(struct xe_device *xe)
>  
>  	xe_pxp_pm_resume(xe->pxp);
>  
> +	xe_late_bind_fw_load(&xe->late_bind);
> +
>  	drm_dbg(&xe->drm, "Device resumed\n");
>  	return 0;
>  err:
> -- 
> 2.34.1
>