linux-kernel - Re: [PATCH net v5 0/4] net: phy: bcm54811: Fix the PHY initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250702150216.2a5410b3@kernel.org>
Date: Wed, 2 Jul 2025 15:02:16 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kamil Horák - 2N <kamilh@...s.com>,
 <florian.fainelli@...adcom.com>
Cc: <bcm-kernel-feedback-list@...adcom.com>, <andrew@...n.ch>,
 <hkallweit1@...il.com>, <linux@...linux.org.uk>, <davem@...emloft.net>,
 <edumazet@...gle.com>, <pabeni@...hat.com>, <krzk+dt@...nel.org>,
 <conor+dt@...nel.org>, <netdev@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <f.fainelli@...il.com>, <robh@...nel.org>, <andrew+netdev@...n.ch>,
 <horms@...nel.org>, <corbet@....net>, <linux-doc@...r.kernel.org>
Subject: Re: [PATCH net v5 0/4] net: phy: bcm54811: Fix the PHY
 initialization

On Tue, 1 Jul 2025 09:50:11 +0200 Kamil Horák - 2N wrote:
> PATCH 1 - Add MII-Lite PHY interface mode as defined by Broadcom for
>    their two-wire PHYs. It can be used with most Ethernet controllers
>    under certain limitations (no half-duplex link modes etc.).
> 
> PATCH 2 - Add MII-Lite PHY interface type
> 
> PATCH 3 - Activation of MII-Lite interface mode on Broadcom bcm5481x
>    PHYs
> 
> PATCH 4 - Fix the BCM54811 PHY initialization so that it conforms
>    to the datasheet regarding a reserved bit in the LRE Control
>    register, which must be written to zero after every device reset.
>    Also fix the LRE Status register reading, there is another bit to
>    be ignored on bcm54811.

I'm a bit lost why the first 3 patches are included in a series for net.
My naive reading is we didn't support this extra mode, now we do,
which sounds like a new feature.. Patch 4, sure, but the dependency
is not obvious.