linux-kernel - Re: [PATCH 01/66] kconfig: set MENU_CHANGED to choice when the selected member is changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46b059f4-2f93-44e0-9a7b-78acb2c02719@infradead.org>
Date: Wed, 2 Jul 2025 15:02:58 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/66] kconfig: set MENU_CHANGED to choice when the
 selected member is changed

On 7/2/25 6:23 AM, Masahiro Yamada wrote:
> On Mon, Jun 30, 2025 at 3:34 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>>
>>
>>
>> On 6/24/25 8:04 AM, Masahiro Yamada wrote:
>>> In gconf, choice entries display the selected symbol in the 'Value'
>>> column, but it is not updated when the selected symbol is changed.
>>>
>>> Set the MENU_CHANGED flag, so it is updated.
>>>
>>> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>>
>> Probably not related to this change (AFAICT), but I was trying to
>> reproduce this problem and I cannot do it.
> 
> You can try this simple test code.
> 
> choice
>         prompt "choose"
> 
> config A
>         bool "A"
> 
> config B
>         bool "B"
> 
> endchoice
> 
> In Full mode, open the tree and double-clock the two
> radio buttons alternatively. (select A or B back-and-forth)
> In the main line code, the Value column of "choose" remains "B".
> 
> After this commit, it starts to react to the change, but the fix is not perfect.
> 
> In the gconfig-v3 branch, this should work perfectly.
> 

OK, confirmed in gconfig-v2 branch.

Tested-by: Randy Dunlap <rdunlap@...radead.org>

One other thing:  if I Quit in today's linux-next (probably similar
to mainline), if the .config file has changed, the Warning box
choices (Yes, No, Cancel) have their first letters underlined and
the Cancel block (just the rectangle itself) is bold, more distinct
than the others, so it must be the default if Enter is pressed.

In the gconfig-v2 branch, the Warning block choices are neither
underlined in their first letter (for us keyboard users) nor is
any one of them Bold (default).  It is a much better UX in the
linux-next/mainline than gconfig-v2.

Is this a change from GTK2 to GTK3?  Unintended?  Fixable?

thanks.

-- 
~Randy