linux-kernel - Re: [RESEND PATCH net-next 1/1] net/mlx5: Clean up only new IRQ glue on request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1b697de-ea53-4634-9821-f403090d3e09@oracle.com>
Date: Wed, 2 Jul 2025 10:37:59 +0530
From: Mohith Kumar Thummaluru <mohith.k.kumar.thummaluru@...cle.com>
To: Jacob Keller <jacob.e.keller@...el.com>,
        "saeedm@...dia.com" <saeedm@...dia.com>,
        "leon@...nel.org"
 <leon@...nel.org>,
        "tariqt@...dia.com" <tariqt@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com"
 <pabeni@...hat.com>,
        "shayd@...dia.com" <shayd@...dia.com>,
        "elic@...dia.com" <elic@...dia.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anand Khoje <anand.a.khoje@...cle.com>,
        Manjunath Patil <manjunath.b.patil@...cle.com>,
        Rama Nichanamatlu <rama.nichanamatlu@...cle.com>,
        Rajesh Sivaramasubramaniom <rajesh.sivaramasubramaniom@...cle.com>,
        Rohit Sajan Kumar <rohit.sajan.kumar@...cle.com>,
        Qing Huang <qing.huang@...cle.com>, Mark Bloch <mbloch@...dia.com>
Subject: Re: [RESEND PATCH net-next 1/1] net/mlx5: Clean up only new IRQ glue
 on request_irq() failure


On 02/07/25 2:21 am, Jacob Keller wrote:
>
> On 6/25/2025 10:32 PM, Mohith Kumar Thummaluru wrote:
>> The mlx5_irq_alloc() function can inadvertently free the entire rmap
>> and end up in a crash[1] when the other threads tries to access this,
>> when request_irq() fails due to exhausted IRQ vectors. This commit
>> modifies the cleanup to remove only the specific IRQ mapping that was
>> just added.
>>
>> This prevents removal of other valid mappings and ensures precise
>> cleanup of the failed IRQ allocation's associated glue object.
>>
>> Note: This error is observed when both fwctl and rds configs are enabled.
>>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks for the review, Jacob!

Based on Mark Bloch's input, I’ve sent out another patch targeting the 
net tree. You can find it here:
https://lore.kernel.org/netdev/1eda4785-6e3e-4660-ac04-62e474133d71@oracle.com/

Regards,
Mohith Kumar Thummaluru