linux-kernel - Re: [RFC PATCH v2 1/1] scsi: mpi3mr: Introduce smp_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cks7tursyprqsq5dp3axagtozduzw2et2hdhbllcv6gqay2rup@f7udfe7c5fza>
Date: Tue, 1 Jul 2025 20:30:06 -0400
From: Aaron Tomlin <atomlin@...mlin.com>
To: Daniel Wagner <dwagner@...e.de>
Cc: Christoph Hellwig <hch@...radead.org>, 
	John Garry <john.g.garry@...cle.com>, Daniel Wagner <wagi@...nel.org>, "Sean A." <sean@...e.io>, 
	"James.Bottomley@...senpartnership.com" <James.Bottomley@...senpartnership.com>, "kashyap.desai@...adcom.com" <kashyap.desai@...adcom.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, 
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>, 
	"mpi3mr-linuxdrv.pdl@...adcom.com" <mpi3mr-linuxdrv.pdl@...adcom.com>, "sreekanth.reddy@...adcom.com" <sreekanth.reddy@...adcom.com>, 
	"sumit.saxena@...adcom.com" <sumit.saxena@...adcom.com>
Subject: Re: [RFC PATCH v2 1/1] scsi: mpi3mr: Introduce smp_affinity_enable
 module parameter

On Tue, Jul 01, 2025 at 03:54:43PM +0200, Daniel Wagner wrote:
> On Wed, Jun 25, 2025 at 09:03:42AM -0400, Aaron Tomlin wrote:
> > Understood. I agree, common functionality is indeed preferred.
> > Daniel, I look forward to your submission.
> 
> Sorry for the delay. I found a few bugs in the new cpu queue mapping
> code and it took a while to debug and fix them all. I should have it
> ready to post by tomorrow. Currently, my brain overheating due to summer
> :)
> 
> FWIW, the last standing issue is that the qla2xxx driver allocates
> queues for scsi and reuses a subset of these queues for nvme. So the irq
> allocating is done for the scsi queues, e.g 16 queues, but the nvme code
> limits it to 8 queues. Currently, there is a disconnect between the irq
> mapping and the cpu mapping code. The solution here is to use the
> irq_get_affinity function instead creating a new map based only on the
> housekeeping cpumask.

Hi Daniel,

No problem and thank you for the update. Excellent! Looking forward to
review.

Kind regards,
-- 
Aaron Tomlin