linux-kernel - Re: [PATCH] samples: mei: Fix building on musl libc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025070224-unheard-viscous-58a5@gregkh>
Date: Wed, 2 Jul 2025 07:45:35 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Brahmajit Das <listout@...tout.xyz>
Cc: linux-kernel@...r.kernel.org, alexander.usyskin@...el.com,
	tomas.winkler@...el.com
Subject: Re: [PATCH] samples: mei: Fix building on musl libc

On Tue, Jul 01, 2025 at 09:37:26PM +0530, Brahmajit Das wrote:
> The header bits/wordsize.h is glibc specific and on building on musl
> with allyesconfig results in
> 
> samples/mei/mei-amt-version.c:77:10: fatal error: bits/wordsize.h: No such file or directory
>    77 | #include <bits/wordsize.h>
>       |          ^~~~~~~~~~~~~~~~~
> 
> mei-amt-version.c build file without bits/wordsize.h on musl and glibc.
> 
> However on musl we get the follwing error without sys/time.h
> 
> samples/mei/mei-amt-version.c: In function 'mei_recv_msg':
> samples/mei/mei-amt-version.c:159:24: error: storage size of 'tv' isn't known
>   159 |         struct timeval tv;
>       |                        ^~
> samples/mei/mei-amt-version.c:160:9: error: unknown type name 'fd_set'
>   160 |         fd_set set;
>       |         ^~~~~~
> samples/mei/mei-amt-version.c:168:9: error: implicit declaration of function 'FD_ZERO' [-Wimplicit-function-declaration]
>   168 |         FD_ZERO(&set);
>       |         ^~~~~~~
> samples/mei/mei-amt-version.c:169:9: error: implicit declaration of function 'FD_SET'; did you mean 'L_SET'? [-Wimplicit-function-declaration]
>   169 |         FD_SET(me->fd, &set);
>       |         ^~~~~~
>       |         L_SET
> samples/mei/mei-amt-version.c:170:14: error: implicit declaration of function 'select' [-Wimplicit-function-declaration]
>   170 |         rc = select(me->fd + 1, &set, NULL, NULL, &tv);
>       |              ^~~~~~
> samples/mei/mei-amt-version.c:171:23: error: implicit declaration of function 'FD_ISSET' [-Wimplicit-function-declaration]
>   171 |         if (rc > 0 && FD_ISSET(me->fd, &set)) {
>       |                       ^~~~~~~~
> samples/mei/mei-amt-version.c:159:24: warning: unused variable 'tv' [-Wunused-variable]
>   159 |         struct timeval tv;
>       |                        ^~
> 
> Hence the the file has been included.
> 
> Signed-off-by: Brahmajit Das <listout@...tout.xyz>
> ---
>  samples/mei/mei-amt-version.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What commit id does this fix?

thanks,

greg k-h