[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1f24f1d3-b28d-4cbf-a165-d857a581032c@kernel.org>
Date: Wed, 2 Jul 2025 08:08:06 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sowon Na <sowon.na@...sung.com>, robh@...nel.org, conor+dt@...nel.org,
vkoul@...nel.org, alim.akhtar@...sung.com, kishon@...nel.org
Cc: krzk+dt@...nel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: exynosautov920: enable support for ufs
device
On 02/07/2025 03:33, Sowon Na wrote:
> The exynosautov920 uses v3.1 UFS device.
> Add ufs node for ExynosAutov920 SoC.
> And enable ufs_phy and ufs devices with ufs_fixed_vcc_reg regulator for
> ExynosAutov920 SADK.
>
> Signed-off-by: Sowon Na <sowon.na@...sung.com>
> ---
> .../boot/dts/exynos/exynosautov920-sadk.dts | 17 ++++++++++++
> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 27 +++++++++++++++++++
> 2 files changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> index a397f068ed53..f979cc1ae6a1 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> @@ -52,6 +52,14 @@ memory@...00000 {
> <0x8 0x80000000 0x1 0xfba00000>,
> <0xa 0x00000000 0x2 0x00000000>;
> };
> +
> + ufs_fixed_vcc_reg: regulator-0 {
This should be somehow related to real name. Schematics don't call
regulators "fixed" or "non-fixed", which makes me think that you forgot
to implement PMIC.
Best regards,
Krzysztof
Powered by blists - more mailing lists