linux-kernel - Re: [PATCH v4 06/10] dt-bindings: i3c: cdns: add Axiado AX3000 I3C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c03c2251-9bf0-45b6-94d8-1ff3b5d7bcfd@kernel.org>
Date: Wed, 2 Jul 2025 08:20:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Harshit Shah <hshah@...ado.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Arnd Bergmann <arnd@...db.de>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Jan Kotas <jank@...ence.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>,
 Michal Simek <michal.simek@....com>, Przemysław Gaj
 <pgaj@...ence.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Frank Li <Frank.Li@....com>, Boris Brezillon <bbrezillon@...nel.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
 soc@...ts.linux.dev, linux-serial@...r.kernel.org,
 linux-i3c@...ts.infradead.org
Subject: Re: [PATCH v4 06/10] dt-bindings: i3c: cdns: add Axiado AX3000 I3C
 controller

On 01/07/2025 22:27, Harshit Shah wrote:
> Add binding for AX3000 I3C controller. So far, no changes known,
> so it can fallback to default compatible.
> 
> Signed-off-by: Harshit Shah <hshah@...ado.com>
> ---
>  Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml
> index cad6d53d0e2e35ddaaad35215ec93dd182f28319..bd3f31a03376b3351276ae2cd247615ee4eff52f 100644
> --- a/Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml
> @@ -14,7 +14,13 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: cdns,i3c-master
> +    oneOf:
> +      - description: Cadence I3C controller
> +        const: cdns,i3c-master
> +      - description: Axiado AX3000 I3C controller

Same comments, drop descriptions,

> +        items:
> +          - const: axiado,ax3000-i3c

This should be enum.

> +          - const: cdns,i3c-master
>  
>    reg:
>      maxItems: 1
> 


Best regards,
Krzysztof