linux-kernel - Re: [PATCH v9 0/4] Enable debugfs information based on client-id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1c87f95832a27c4435a24223ac5a715cbdd38c2.camel@mailbox.org>
Date: Wed, 02 Jul 2025 08:21:48 +0200
From: Philipp Stanner <phasta@...lbox.org>
To: Sunil Khatri <sunil.khatri@....com>, Christian König
	 <christian.koenig@....com>, dri-devel@...ts.freedesktop.org
Cc: amd-gfx@...ts.freedesktop.org, simona@...ll.ch, tzimmermann@...e.de, 
	tursulin@...ulin.net, phasta@...nel.org, dakr@...nel.org, 
	linux-kernel@...r.kernel.org, Oded Gabbay <ogabbay@...nel.org>, Jeff Hugo
	 <jeff.hugo@....qualcomm.com>
Subject: Re: [PATCH v9 0/4] Enable debugfs information based on client-id

On Tue, 2025-07-01 at 22:19 +0530, Sunil Khatri wrote:
> client-id is a unique id across the system no matter if its from a VM
> or on a host system. This unique id is a good base to use create
> client-id based dentry in debugfs in the root directory.
> 
> This directory could be a unique directory where drivers could dump
> the debug information.
> 
> For amdgpu driver, we want to dump the VM PTBASE address and MQD for 
> userqueue which can be used by a tool like amd umr to dump the memory
> and that is really important to debug userqueues and VM related
> issues.
> 
> One of the challenge in this how to access the root directory which
> is
> beyond the drm_device hence moving the debugfs related information to
> drm_debugfs.c 
> 
> Sunil Khatri (4):
>   drm: move drm based debugfs funcs to drm_debugfs.c
>   drm: add debugfs support on per client-id basis
>   drm/amdgpu: add debugfs support for VM pagetable per client
>   drm/amdgpu: add support of debugfs for mqd information

Hi,

please wait >24h before sending new versions of a series, so that more
people can opt in and traffic on the lists gets reduced

Thx


> 
>  drivers/accel/drm_accel.c                   |  16 ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |  52 +++++++++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h |   1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c     |   2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c   |  52 +++++++++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h   |   1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c      |   4 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h      |   4 +-
>  drivers/gpu/drm/drm_debugfs.c               | 113
> ++++++++++++++++++--
>  drivers/gpu/drm/drm_drv.c                   |  14 +--
>  drivers/gpu/drm/drm_file.c                  |   9 ++
>  drivers/gpu/drm/drm_internal.h              |   6 +-
>  include/drm/drm_accel.h                     |   5 -
>  include/drm/drm_debugfs.h                   |  11 ++
>  include/drm/drm_drv.h                       |  14 ++-
>  include/drm/drm_file.h                      |   7 ++
>  16 files changed, 265 insertions(+), 46 deletions(-)
>