linux-kernel - Re: [PATCH 2/7] dt-bindings: soc: imx-blk-ctrl: add MIPI CSI2 dphy support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d22829c-f807-4416-ab5a-87d210ade897@kernel.org>
Date: Wed, 2 Jul 2025 08:40:59 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.Li@....com>, Rui Miguel Silva <rmfrfs@...il.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Martin Kepplinger <martink@...teo.de>, Purism Kernel Team <kernel@...i.sm>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Eugen Hristev <eugen.hristev@...aro.org>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Peng Fan <peng.fan@....com>,
 Alice Yuan <alice.yuan@....com>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org
Subject: Re: [PATCH 2/7] dt-bindings: soc: imx-blk-ctrl: add MIPI CSI2 dphy
 support

On 02/07/2025 00:06, Frank Li wrote:
> Add child node dphy-rx, which export phys interface to MIPI CSI2
> controller.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> imx media blk ctrl combined many small glue logic registers for display
> , camera, power, clk and reset.
> 
> There are some discussion at
> https://lore.kernel.org/all/4414669.ejJDZkT8p0@steina-w/
> to define whole schema for this.
> 
> But there are some difficults to cover whole once.
> 
> Plan use two steps to complete it
> - add all camera related property and subnode
> - add all display related property and subnode
> ---
>  .../bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
> index b3554e7f9e76d..708cd00f2b896 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
> @@ -46,6 +46,34 @@ properties:
>        - const: csi
>        - const: dsi
>  
> +  dphy-rx:
> +    type: object
> +    properties:
> +      compatible:
> +        enum:
> +          - fsl,imx93-dphy-rx
> +
> +      clocks:
> +        maxItems: 1
> +
> +      clock-names:
> +        items:
> +          - const: cfg
> +
> +      '#phy-cells':
> +        const: 0
> +
> +      power-domains:
> +        maxItems: 1

This looks wrong. How a parent device can take one power domain and
child take a different one? If that's the same, then it is redundant,
because it is part of parent's power domain.

I have also some doubts about clock. Rarely syscon children have their
own resources which would make this entire node redundant.

Provide complete picture on this in commit msg.

> +
> +    required:
> +      - compatible
> +      - clocks
> +      - clock-names
> +      - '#phy-cells'
> +
> +    additionalProperties: false

Please place it after type:.

You also need to update the example.
> +
>  required:
>    - compatible
>    - reg
> 


Best regards,
Krzysztof