linux-kernel - [PATCH v4 2/4] pinctrl: renesas: rzg2l: Pass OEN pin names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250702005706.1200059-3-john.madieu.xa@bp.renesas.com>
Date: Wed,  2 Jul 2025 02:57:04 +0200
From: John Madieu <john.madieu.xa@...renesas.com>
To: geert+renesas@...der.be,
	magnus.damm@...il.com,
	robh@...nel.org,
	krzk+dt@...nel.org,
	conor+dt@...nel.org,
	mturquette@...libre.com,
	sboyd@...nel.org,
	richardcochran@...il.com,
	prabhakar.mahadev-lad.rj@...renesas.com
Cc: linux-renesas-soc@...r.kernel.org,
	devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-clk@...r.kernel.org,
	netdev@...r.kernel.org,
	biju.das.jz@...renesas.com,
	john.madieu@...il.com
Subject: [PATCH v4 2/4] pinctrl: renesas: rzg2l: Pass OEN pin names

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Pass the OEN pin names via the SoC-specific hardware configuration
structure to allow reuse of rzv2h_oen_read() and rzv2h_oen_write()
on multiple SoCs.

On the RZ/V2H(P) and RZ/G3E SoCs, the PFC_OEN register is located at the
same offset. However, the register controls different pins on each SoC.
Hardcoding the pin names in the common logic prevents reusability.

Extend struct rzg2l_hwcfg to include an array of OEN pin names and its
length. Use these values in rzv2h_pin_to_oen_bit() to determine the bit
position dynamically based on the active SoC.

This enables shared handling of OEN register access while accounting for
SoC-specific pin mappings.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
---

Changes:

v4: new patch

 drivers/pinctrl/renesas/pinctrl-rzg2l.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index 78fa08ff0faa..792ca70bd9d1 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -257,6 +257,8 @@ enum rzg2l_iolh_index {
  * @func_base: base number for port function (see register PFC)
  * @oen_max_pin: the maximum pin number supporting output enable
  * @oen_max_port: the maximum port number supporting output enable
+ * @oen_pin_names: array of pin names for output enable
+ * @oen_pin_names_len: length of the oen_pin_names array
  */
 struct rzg2l_hwcfg {
 	const struct rzg2l_register_offsets regs;
@@ -269,6 +271,8 @@ struct rzg2l_hwcfg {
 	u8 func_base;
 	u8 oen_max_pin;
 	u8 oen_max_port;
+	const char * const *oen_pin_names;
+	u8 oen_pin_names_len;
 };
 
 struct rzg2l_dedicated_configs {
@@ -1213,14 +1217,11 @@ static int rzv2h_bias_param_to_hw(enum pin_config_param param)
 
 static u8 rzv2h_pin_to_oen_bit(struct rzg2l_pinctrl *pctrl, unsigned int _pin)
 {
-	static const char * const pin_names[] = { "ET0_TXC_TXCLK", "ET1_TXC_TXCLK",
-						  "XSPI0_RESET0N", "XSPI0_CS0N",
-						  "XSPI0_CKN", "XSPI0_CKP" };
 	const struct pinctrl_pin_desc *pin_desc = &pctrl->desc.pins[_pin];
 	unsigned int i;
 
-	for (i = 0; i < ARRAY_SIZE(pin_names); i++) {
-		if (!strcmp(pin_desc->name, pin_names[i]))
+	for (i = 0; i < pctrl->data->hwcfg->oen_pin_names_len; i++) {
+		if (!strcmp(pin_desc->name, pctrl->data->hwcfg->oen_pin_names[i]))
 			return i;
 	}
 
@@ -3277,11 +3278,18 @@ static const struct rzg2l_hwcfg rzg3s_hwcfg = {
 	.oen_max_port = 7, /* P7_1 is the maximum OEN port. */
 };
 
+static const char * const rzv2h_oen_pin_names[] = {
+	"ET0_TXC_TXCLK", "ET1_TXC_TXCLK", "XSPI0_RESET0N", "XSPI0_CS0N",
+	"XSPI0_CKN", "XSPI0_CKP"
+};
+
 static const struct rzg2l_hwcfg rzv2h_hwcfg = {
 	.regs = {
 		.pwpr = 0x3c04,
 	},
 	.tint_start_index = 17,
+	.oen_pin_names = rzv2h_oen_pin_names,
+	.oen_pin_names_len = ARRAY_SIZE(rzv2h_oen_pin_names),
 };
 
 static struct rzg2l_pinctrl_data r9a07g043_data = {
-- 
2.25.1