linux-kernel - Re: [PATCH v2 2/3] cxl/edac: Fix wrong dpa checking for PPR operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGTsyw4iq5mFLDPg@smile.fi.intel.com>
Date: Wed, 2 Jul 2025 11:24:43 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Li Ming <ming.li@...omail.com>
Cc: akpm@...ux-foundation.org, bhelgaas@...gle.com,
	ilpo.jarvinen@...ux.intel.com, dave@...olabs.net,
	jonathan.cameron@...wei.com, dave.jiang@...el.com,
	alison.schofield@...el.com, vishal.l.verma@...el.com,
	ira.weiny@...el.com, dan.j.williams@...el.com,
	shiju.jose@...wei.com, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] cxl/edac: Fix wrong dpa checking for PPR operation

On Wed, Jul 02, 2025 at 03:20:07PM +0800, Li Ming wrote:
> DPA 0 is considered invalid in cxl_do_ppr(), but per Table 8-143. "Get
> Partition Info Output Payload" in CXL r3.2 section 8.2.10.9.2.1 "Get
> Partition Info(Opcode 4100h)", it mentions that DPA 0 is a valid address
> of a CXL device. So the correct implementation should be checking if the
> DPA is in the DPA range of the CXL device rather than checking if the
> DPA is equal to 0.

Looking at the use cases, I even like the first patch less. You can do
it locally in the macro or function in cxl code. We may see in the future
if something like this will be needed for others.

-- 
With Best Regards,
Andy Shevchenko