linux-kernel - Re: [PATCH v2 0/5] block/md/dm: set chunk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510bee79-9098-49fe-8449-c66366f73372@oracle.com>
Date: Wed, 2 Jul 2025 09:28:54 +0100
From: John Garry <john.g.garry@...cle.com>
To: agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com, song@...nel.org,
        yukuai3@...wei.com, hch@....de, nilay@...ux.ibm.com, axboe@...nel.dk
Cc: dm-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-raid@...r.kernel.org, linux-block@...r.kernel.org,
        ojaswin@...ux.ibm.com, martin.petersen@...cle.com
Subject: Re: [PATCH v2 0/5] block/md/dm: set chunk_sectors from stacked dev
 stripe size

On 26/06/2025 10:36, John Garry wrote:
 > On 18/06/2025 09:37, John Garry wrote:

Hi Jens,

Could you kindly consider picking up this series via the block tree?

I was hoping for a maintainer ack on the md raid0/1/10 stuff, but it's 
quite a straightforward change there.

Cheers,
John

>> This value in io_min is used to configure any atomic write limit for the
>> stacked device. The idea is that the atomic write unit max is a
>> power-of-2 factor of the stripe size, and the stripe size is available
>> in io_min.
>>
>> Using io_min causes issues, as:
>> a. it may be mutated
>> b. the check for io_min being set for determining if we are dealing with
>> a striped device is hard to get right, as reported in [0].
>>
>> This series now sets chunk_sectors limit to share stripe size.
> 
> Any more comments here? It would be good to have the md/raid0 and md/ 
> raid10 changes checked by the md maintainers.
> 
> Thanks
> 
>>
>> [0] https://urldefense.com/v3/__https://lore.kernel.org/linux- 
>> block/888f3b1d-7817-4007-b3b3-1a2ea04df771@...ux.ibm.com/T/ 
>> *mecca17129f72811137d3c2f1e477634e77f06781__;Iw!!ACWV5N9M2RV99hQ! 
>> I8diqGp3zAZO162eEpQ1SuUsrvAMTWzhbHUSxxn23h3TLcRRTAs3LUDanOeWiK2osXVfFD0HHw4PioWzfd6MhbOnyw$
>> Based on v6.16-rc2
>>
>> Differences to RFC:
>> - sanitize chunk_sectors for atomic write limits
>> - set chunk_sectors in stripe_io_hints()
>>
>> John Garry (5):
>>    block: sanitize chunk_sectors for atomic write limits
>>    md/raid0: set chunk_sectors limit
>>    md/raid10: set chunk_sectors limit
>>    dm-stripe: limit chunk_sectors to the stripe size
>>    block: use chunk_sectors when evaluating stacked atomic write limits
>>
>>   block/blk-settings.c   | 60 ++++++++++++++++++++++++++----------------
>>   drivers/md/dm-stripe.c |  1 +
>>   drivers/md/raid0.c     |  1 +
>>   drivers/md/raid10.c    |  1 +
>>   4 files changed, 40 insertions(+), 23 deletions(-)