linux-kernel - Re: [PATCH v4 net-next 1/3] net: hibmcge: support scenario without PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c0d95ce-7c38-42d7-b45e-e7d388b57ede@huawei.com>
Date: Wed, 2 Jul 2025 09:04:35 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <andrew+netdev@...n.ch>,
	<horms@...nel.org>, <shenjian15@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 net-next 1/3] net: hibmcge: support scenario without
 PHY


on 2025/7/2 6:07, Andrew Lunn wrote:
>> +	phydev = fixed_phy_register(&hbg_fixed_phy_status, NULL);
>> +	if (IS_ERR(phydev)) {
>> +		dev_err_probe(dev, IS_ERR(phydev),
> IS_ERR() returns a bool, where as dev_err_probe() expects an int.

Yeah,
PTR_ERR(phydev) should be used in there

Thanks,
Jijie Shao

>
>> +			      "failed to register fixed PHY device\n");
>> +		return IS_ERR(phydev);
> This also looks wrong.
>
>      Andrew
>
> ---
> pw-bot: cr