linux-kernel - re: drm/bridge: tc358767: convert to devm_drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <056b34c3-c1ea-4b8c-9672-c98903ffd012@gmail.com>
Date: Wed, 2 Jul 2025 10:41:52 +0100
From: "Colin King (gmail)" <colin.i.king@...il.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: re: drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API

Hi,

I believe there is a regression in linux-next caused by the following 
commit:

commit a59a271769149f0b8258507276f3d2a24370cbdb
Author: Luca Ceresoli <luca.ceresoli@...tlin.com>
Date:   Wed May 28 11:29:36 2025 +0200

     drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API


the issue is as follows:

static int tc_probe_bridge_endpoint(struct tc_data *tc, enum tc_mode mode)
{
         struct device *dev = tc->dev;
         struct of_endpoint endpoint;
         struct device_node *node = NULL;

         for_each_endpoint_of_node(dev->of_node, node) {
                 if (endpoint.port == 2) {
			...
			...

The check for endpoint.port == 2 is checking an uninitialized field in 
the uninitialized structure endpoint. The code before this commit called 
  of_graph_parse_endpoint(node, &endpoint) to fetch endpoint and now 
this seems to be missing.

Colin



Download attachment "OpenPGP_0x68C287DFC6A80226.asc" of type "application/pgp-keys" (4825 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)