linux-kernel - Re: [RFC RESEND v10 00/14] Refcounted interrupts, SpinLockIrq for rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DB1HPGT5MG09.25OEO7K36RNKX@kernel.org>
Date: Wed, 02 Jul 2025 12:16:47 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Lyude Paul" <lyude@...hat.com>, <rust-for-linux@...r.kernel.org>,
 "Thomas Gleixner" <tglx@...utronix.de>, "Boqun Feng"
 <boqun.feng@...il.com>, <linux-kernel@...r.kernel.org>, "Daniel Almeida"
 <daniel.almeida@...labora.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "Danilo Krummrich" <dakr@...nel.org>
Subject: Re: [RFC RESEND v10 00/14] Refcounted interrupts, SpinLockIrq for
 rust

On Wed May 28, 2025 at 12:21 AM CEST, Lyude Paul wrote:
> Hi! While this patch series still needs some changes on the C side, I
> wanted to update things and send out the latest version of it that's
> been sitting on my machine for a while now. This adds back the
> mistakenly missing commit messages along with a number of other changes
> that were requested.
>
> Please keep in mind, there are still some issues with this patch series
> that I do need help with solving before it can move forward:
>
> * https://lore.kernel.org/rust-for-linux/ZxrCrlg1XvaTtJ1I@boqun-archlinux/
> * Concerns around double checking the HARDIRQ bits against all
>   architectures that have interrupt priority support. I know what IPL is
>   but I really don't have a clear understanding of how this actually
>   fits together in the kernel's codebase or even how to find the
>   documentation for many of the architectures involved here.
>
>   Please help :C! If you want these rust bindings, figuring out these
>   two issues will let this patch seires move forward.
>
> The previous version of this patch series can be found here:
>
> https://lore.kernel.org/rust-for-linux/20250227221924.265259-4-lyude@redhat.com/T/

Overall I think it looks good, I haven't checked the details though.
IIUC, the C side will also change a bit, inducing some more changes on
the Rust side as well, so I'll just take a look when this becomes a
normal patch series :)

Thanks for the hard work Lyude & Boqun!

---
Cheers,
Benno

> Boqun Feng (6):
>   preempt: Introduce HARDIRQ_DISABLE_BITS
>   preempt: Introduce __preempt_count_{sub, add}_return()
>   irq & spin_lock: Add counted interrupt disabling/enabling
>   rust: helper: Add spin_{un,}lock_irq_{enable,disable}() helpers
>   rust: sync: lock: Add `Backend::BackendInContext`
>   locking: Switch to _irq_{disable,enable}() variants in cleanup guards
>
> Lyude Paul (8):
>   rust: Introduce interrupt module
>   rust: sync: Add SpinLockIrq
>   rust: sync: Introduce lock::Backend::Context
>   rust: sync: Add a lifetime parameter to lock::global::GlobalGuard
>   rust: sync: lock/global: Rename B to G in trait bounds
>   rust: sync: Expose lock::Backend
>   rust: sync: lock/global: Add Backend parameter to GlobalGuard
>   rust: sync: lock/global: Add BackendInContext support to GlobalLock
>
>  arch/arm64/include/asm/preempt.h  |  18 +++
>  arch/s390/include/asm/preempt.h   |  19 +++
>  arch/x86/include/asm/preempt.h    |  10 ++
>  include/asm-generic/preempt.h     |  14 +++
>  include/linux/irqflags.h          |   1 -
>  include/linux/irqflags_types.h    |   6 +
>  include/linux/preempt.h           |  20 +++-
>  include/linux/spinlock.h          |  88 +++++++++++---
>  include/linux/spinlock_api_smp.h  |  27 +++++
>  include/linux/spinlock_api_up.h   |   8 ++
>  include/linux/spinlock_rt.h       |  16 +++
>  kernel/locking/spinlock.c         |  31 +++++
>  kernel/softirq.c                  |   3 +
>  rust/helpers/helpers.c            |   1 +
>  rust/helpers/interrupt.c          |  18 +++
>  rust/helpers/spinlock.c           |  15 +++
>  rust/kernel/interrupt.rs          |  83 +++++++++++++
>  rust/kernel/lib.rs                |   1 +
>  rust/kernel/sync.rs               |   5 +-
>  rust/kernel/sync/lock.rs          |  69 ++++++++++-
>  rust/kernel/sync/lock/global.rs   |  91 ++++++++++-----
>  rust/kernel/sync/lock/mutex.rs    |   2 +
>  rust/kernel/sync/lock/spinlock.rs | 186 ++++++++++++++++++++++++++++++
>  23 files changed, 680 insertions(+), 52 deletions(-)
>  create mode 100644 rust/helpers/interrupt.c
>  create mode 100644 rust/kernel/interrupt.rs
>
>
> base-commit: a3b2347343e077e81d3c169f32c9b2cb1364f4cc