linux-kernel - Re: [PATCH v7 00/12] iio: adc: Add support for AD4170 series of ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGUfapky2uh2tsFt@debian-BULLSEYE-live-builder-AMD64>
Date: Wed, 2 Jul 2025 09:00:42 -0300
From: Marcelo Schmitt <marcelo.schmitt1@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, jic23@...nel.org, lars@...afoo.de,
	Michael.Hennerich@...log.com, dlechner@...libre.com,
	nuno.sa@...log.com, andy@...nel.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, linus.walleij@...aro.org,
	brgl@...ev.pl, broonie@...nel.org, lgirdwood@...il.com
Subject: Re: [PATCH v7 00/12] iio: adc: Add support for AD4170 series of ADCs

On 07/02, Andy Shevchenko wrote:
> On Mon, Jun 30, 2025 at 10:57:32AM -0300, Marcelo Schmitt wrote:
> > Hello,
> > 
> > AD4170 support v7 comes after testing the driver with even more variations of
> > channel setups. Signal offset and amplification can be tricky to grasp at times.
> > 
> > Thank you to all reviewers of previous versions. This intends to comply with all
> > comments and suggestions to v6.
> > 
> > Same amount of patches than v6.
> 
> ...
> 
> >  6 files changed, 3601 insertions(+)
> 
> This is weird. At least patches 11 & 12 have '-' lines...
> 
Yeah, sorry about that. These ADCs are fancy such that the base driver is about
1500 LoCs due to channel setup handling and support for multiple combinations of
voltage references and channel setups.

About the '-' lines, I will rework ad4170_parse_channel_node() on earlier
patches to avoid 3 line removals in patch 11. Patch 12 is only makes sense
after patch 7 and I think it would lead to '-' lines if coming before patch 10
since both increment the number of IIO channels. Anyway, I'll see how to further
reduce the number of lines being removed.


Best regards,
Marcelo

> -- 
> With Best Regards,
> Andy Shevchenko
> 
>