linux-kernel - Re: [PATCH v6 2/4] thermal/drivers/exynos: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250702120015.350609-1-m.majewski2@samsung.com>
Date: Wed,  2 Jul 2025 14:00:15 +0200
From: Mateusz Majewski <m.majewski2@...sung.com>
To: linux.amoon@...il.com
Cc: alim.akhtar@...sung.com, bzolnier@...il.com, daniel.lezcano@...aro.org,
	justinstitt@...gle.com, krzk@...nel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	llvm@...ts.linux.dev, lukasz.luba@....com, morbo@...gle.com,
	nathan@...nel.org, nick.desaulniers+lkml@...il.com, rafael@...nel.org,
	rui.zhang@...el.com
Subject: Re: [PATCH v6 2/4] thermal/drivers/exynos: Use
 devm_clk_get_enabled() helpers

Hello :)

These:

> +	data->clk = devm_clk_get_enabled(dev, "tmu_apbif");

> +		data->clk_sec = devm_clk_get_enabled(dev, "tmu_triminfo_apbif");

should probably call devm_clk_get_prepared instead, as they are only
prepared inside current code:

> -	ret = clk_prepare(data->clk);

> -		ret = clk_prepare(data->clk_sec);

as elsewhere they are only enabled on use and then disabled. Only
data->sclk is enabled immediately:

> -			ret = clk_prepare_enable(data->sclk);

Thank you,
Mateusz Majewski