linux-kernel - RE: [PATCH v4 4/4] arm64: dts: renesas: rzg3e-smarc-som: Enable eth{0-1} (GBETH) interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <OSCPR01MB14647F33648B9BD6CC70AF9FEFF40A@OSCPR01MB14647.jpnprd01.prod.outlook.com>
Date: Wed, 2 Jul 2025 12:28:05 +0000
From: John Madieu <john.madieu.xa@...renesas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
CC: "magnus.damm@...il.com" <magnus.damm@...il.com>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "mturquette@...libre.com"
	<mturquette@...libre.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
	"richardcochran@...il.com" <richardcochran@...il.com>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Biju Das
	<biju.das.jz@...renesas.com>, "john.madieu@...il.com" <john.madieu@...il.com>
Subject: RE: [PATCH v4 4/4] arm64: dts: renesas: rzg3e-smarc-som: Enable
 eth{0-1} (GBETH) interfaces

Hi Geert,

Thanks for your review.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: Wednesday, July 2, 2025 11:03 AM
> To: John Madieu <john.madieu.xa@...renesas.com>
> Subject: Re: [PATCH v4 4/4] arm64: dts: renesas: rzg3e-smarc-som: Enable
> eth{0-1} (GBETH) interfaces
> 
> Hi John,
> 
> On Wed, 2 Jul 2025 at 02:57, John Madieu <john.madieu.xa@...renesas.com>
> wrote:
> > Enable the Gigabit Ethernet Interfaces (GBETH) populated on the RZ/G3E
> > SMARC EVK
> >
> > Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>
> 
> > v4:
> >  - Update pinmux to add OEN support
> >  - Drops Tb and Rb tags initially collected
> 
> Thanks for the update!
> 
> > --- a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> >  &pinctrl {
> > +       eth0_pins: eth0 {
> > +               clk0 {
> 
> No need for the 0 ...
> 
> > +                       pinmux = <RZG3E_PORT_PINMUX(B, 1, 1)>; /* TXC */
> > +                       output-enable;
> > +               };
> > +
> > +               ctrl0 {
> 
> ... suffixes...
> 
> > +       eth1_pins: eth1 {
> > +               clk1 {
> 
> ... or the 1...
> 
> > +                       pinmux = <RZG3E_PORT_PINMUX(E, 1, 1)>; /* TXC */
> > +                       output-enable;
> > +               };
> > +
> > +               ctrl1 {
> 
> ... suffixes.
> 
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be> i.e. will queue in
> renesas-devel for v6.17 with the above fixed.

Thanks for taking care of that.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 

Regards,
John

> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
>                                 -- Linus Torvalds