linux-kernel - Re: [PATCH v6 2/3] mfd: ls2kbmc: Add Loongson-2K BMC reset function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpQs4+hrJ8B4wZRmCH2T7wLAwnmD8_WH2OpNLWH64AbanZ-pw@mail.gmail.com>
Date: Thu, 3 Jul 2025 10:07:26 +0800
From: Binbin Zhou <zhoubb.aaron@...il.com>
To: Lee Jones <lee@...nel.org>
Cc: kernel test robot <lkp@...el.com>, Binbin Zhou <zhoubinbin@...ngson.cn>, 
	Huacai Chen <chenhuacai@...ngson.cn>, Corey Minyard <minyard@....org>, oe-kbuild-all@...ts.linux.dev, 
	Xuerui Wang <kernel@...0n.name>, loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	openipmi-developer@...ts.sourceforge.net, jeffbai@...c.io, 
	kexybiscuit@...c.io, wangyao@...ote.com, Chong Qiao <qiaochong@...ngson.cn>
Subject: Re: [PATCH v6 2/3] mfd: ls2kbmc: Add Loongson-2K BMC reset function support

Hi Lee:

On Thu, Jul 3, 2025 at 12:23 AM Lee Jones <lee@...nel.org> wrote:
>
> On Wed, 02 Jul 2025, kernel test robot wrote:
>
> > Hi Binbin,
> >
> > kernel test robot noticed the following build errors:
> >
> > [auto build test ERROR on 3d77b3cc7cc8115d89fa14eaf601e56372953484]
> >
> > url:    https://github.com/intel-lab-lkp/linux/commits/Binbin-Zhou/mfd-ls2kbmc-Introduce-Loongson-2K-BMC-core-driver/20250626-203353
> > base:   3d77b3cc7cc8115d89fa14eaf601e56372953484
> > patch link:    https://lore.kernel.org/r/78b06d1c7ae0677868e0c7498b589af163313c8d.1750939357.git.zhoubinbin%40loongson.cn
> > patch subject: [PATCH v6 2/3] mfd: ls2kbmc: Add Loongson-2K BMC reset function support
> > config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20250702/202507021011.sDAHGinj-lkp@intel.com/config)
> > compiler: sparc64-linux-gcc (GCC) 15.1.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250702/202507021011.sDAHGinj-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202507021011.sDAHGinj-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/mfd/ls2k-bmc-core.c: In function 'ls2k_bmc_pdata_initial':
> > >> drivers/mfd/ls2k-bmc-core.c:349:15: error: implicit declaration of function 'acpi_register_gsi' [-Wimplicit-function-declaration]
> >      349 |         irq = acpi_register_gsi(NULL, gsi, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW);
> >          |               ^~~~~~~~~~~~~~~~~
> > >> drivers/mfd/ls2k-bmc-core.c:376:9: error: implicit declaration of function 'acpi_unregister_gsi'; did you mean 'arch_unregister_cpu'? [-Wimplicit-function-declaration]
> >      376 |         acpi_unregister_gsi(gsi);
> >          |         ^~~~~~~~~~~~~~~~~~~
> >          |         arch_unregister_cpu
>
> Is this error valid?

Emm...

This error does exist if ACPI_GENERIC_GSI is not selected.
I will add this dependency in the next version.

depends on PCI && ACPI_GENERIC_GSI

>
> --
> Lee Jones [李琼斯]

-- 
Thanks.
Binbin