linux-kernel - Re: [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f692b80-1015-4c9c-ba94-eda9afb919da@tuxedocomputers.com>
Date: Thu, 3 Jul 2025 14:58:29 +0200
From: Georg Gottleuber <ggo@...edocomputers.com>
To: Christoph Hellwig <hch@....de>, Werner Sembach <wse@...edocomputers.com>
Cc: Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
 Sagi Grimberg <sagi@...mberg.me>, Georg Gottleuber
 <ggo@...edocomputers.com>, linux-nvme@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Christoffer Sandberg <cs@...edocomputers.com>
Subject: Re: [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk


Am 03.07.25 um 13:45 schrieb Christoph Hellwig:
> On Tue, Jul 01, 2025 at 10:55:49PM +0200, Werner Sembach wrote:
>> From: Georg Gottleuber <ggo@...edocomputers.com>
>> 
>> On the TUXEDO InfinityBook S Gen8, a Samsung 990 Evo NVMe leads
>> to a high power consumption in s2idle sleep (3.5 watts).
>> 
>> This patch applies 'Force No Simple Suspend' quirk to achieve a 
>> sleep with a lower power consumption, typically around 1 watts.
> 
> Why do we keep getting more and more of these quirks instead of 
> getting the issue root caused and fixed?
> 

Hi, it is not a new quirk but another device. For me the real question
is: Why is NVME_QUIRK_SIMPLE_SUSPEND apparently used for nearly all
NVMes. This is no longer a quirk, but rather the new default.

For some device combinations, it just works better without this quirk.
That's why I set NVME_QUIRK_FORCE_NO_SIMPLE_SUSPEND.

Best regards,
Georg