linux-kernel - Re: [PATCH 2/2] gpio: pca953x: Add support for TI TCA6418

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MeEj574YPgX17S8z5Z0miaksWw-2NQMhpwsjNL0z8FT-w@mail.gmail.com>
Date: Thu, 3 Jul 2025 15:07:56 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Maria Garcia <mariagarcia7293@...il.com>
Cc: linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Maria Garcia <mgarcia@...ox.com>
Subject: Re: [PATCH 2/2] gpio: pca953x: Add support for TI TCA6418

On Wed, Jun 25, 2025 at 1:53 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> >
> > +static u8 tca6418_recalc_addr(struct pca953x_chip *chip, int reg_base, int offset)
> > +{
> > +       /* reg_base will be TCA6418_INPUT, TCA6418_OUTPUT, or TCA6418_DIRECTION
> > +        * offset is the global GPIO line offset (0-17)
> > +        * BANK_SZ is 8 for TCA6418 (8 bits per register bank)
> > +        */
>
> Please use regular kernel comments, not the networking style.
>

I asked for this under version 1. It's still not fixed in version 3.

Bart