linux-kernel - Re: [PATCH] ACPI: processor: fix acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0huBwxiop1ZJ7reXyir42vjgm7xehn+xnhfe7RDwu9EGQ@mail.gmail.com>
Date: Thu, 3 Jul 2025 15:28:23 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Sebastian Ott <sebott@...hat.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: processor: fix acpi_object initialization

On Thu, Jul 3, 2025 at 2:42 PM Sebastian Ott <sebott@...hat.com> wrote:
>
> Initialization of the local acpi_object in acpi_processor_get_info()
> only sets the first 4 bytes to zero and is thus incomplete. This is
> indicated by messages like:
>         acpi ACPI0007:be: Invalid PBLK length [166288104]
>
> Fix this by initializing all 16 bytes of the processor member of that
> union.
>
> Signed-off-by: Sebastian Ott <sebott@...hat.com>
> ---
>  drivers/acpi/acpi_processor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
> index 7cf6101cb4c7..2a99f5eb6962 100644
> --- a/drivers/acpi/acpi_processor.c
> +++ b/drivers/acpi/acpi_processor.c
> @@ -275,7 +275,7 @@ static inline int acpi_processor_hotadd_init(struct acpi_processor *pr,
>
>  static int acpi_processor_get_info(struct acpi_device *device)
>  {
> -       union acpi_object object = { 0 };
> +       union acpi_object object = { .processor = { 0 } };
>         struct acpi_buffer buffer = { sizeof(union acpi_object), &object };
>         struct acpi_processor *pr = acpi_driver_data(device);
>         int device_declaration = 0;
> --

Applied as 6.17 material, thanks!