linux-kernel - Re: [PATCH] PCI: Fix pci devices double register WARN in the kernel starting process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507032253.sXSgz4lH-lkp@intel.com>
Date: Thu, 3 Jul 2025 23:09:05 +0800
From: kernel test robot <lkp@...el.com>
To: Shuan He <heshuan@...edance.com>, bhelgaas@...gle.com,
	cuiyunhui@...edance.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, heshuan@...edance.com,
	sunilvl@...tanamicro.com
Subject: Re: [PATCH] PCI: Fix pci devices double register WARN in the kernel
 starting process

Hi Shuan,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus linus/master v6.16-rc4 next-20250703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shuan-He/PCI-Fix-pci-devices-double-register-WARN-in-the-kernel-starting-process/20250703-035442
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20250702155112.40124-2-heshuan%40bytedance.com
patch subject: [PATCH] PCI: Fix pci devices double register WARN in the kernel starting process
config: alpha-allnoconfig (https://download.01.org/0day-ci/archive/20250703/202507032253.sXSgz4lH-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250703/202507032253.sXSgz4lH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507032253.sXSgz4lH-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/pci/proc.c: In function 'pci_proc_init':
>> drivers/pci/proc.c:476:25: error: too many arguments to function 'pci_dev_assign_added'; expected 1, have 2
     476 |                         pci_dev_assign_added(dev, true);
         |                         ^~~~~~~~~~~~~~~~~~~~      ~~~~
   In file included from drivers/pci/proc.c:18:
   drivers/pci/pci.h:577:20: note: declared here
     577 | static inline void pci_dev_assign_added(struct pci_dev *dev)
         |                    ^~~~~~~~~~~~~~~~~~~~


vim +/pci_dev_assign_added +476 drivers/pci/proc.c

   463	
   464	static int __init pci_proc_init(void)
   465	{
   466		struct pci_dev *dev = NULL;
   467		proc_bus_pci_dir = proc_mkdir("bus/pci", NULL);
   468		proc_create_seq("devices", 0, proc_bus_pci_dir,
   469			    &proc_bus_pci_devices_op);
   470		proc_initialized = 1;
   471		pci_lock_rescan_remove();
   472		for_each_pci_dev(dev) {
   473			if (pci_dev_is_added(dev))
   474				continue;
   475			if (!pci_proc_attach_device(dev))
 > 476				pci_dev_assign_added(dev, true);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki