linux-kernel - Re: [PATCH net-next 2/3] net: phy: qcom: qca808x: Fix WoL issue by utilizing at8031_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba80ac3c-2e42-411d-a2b1-b85ed154372d@quicinc.com>
Date: Thu, 3 Jul 2025 23:14:44 +0800
From: Luo Jie <quic_luoj@...cinc.com>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
CC: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "Russell King (Oracle)"
	<rmk+kernel@...linux.org.uk>,
        Viorel Suman <viorel.suman@....com>, Li Yang
	<leoyang.li@....com>,
        Wei Fang <wei.fang@....com>, <netdev@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Luo Jie
	<luoj@....qualcomm.com>
Subject: Re: [PATCH net-next 2/3] net: phy: qcom: qca808x: Fix WoL issue by
 utilizing at8031_set_wol()



On 7/3/2025 10:23 PM, Maxime Chevallier wrote:
> Hi,
> 
> On Thu, 3 Jul 2025 20:14:29 +0800
> Luo Jie <quic_luoj@...cinc.com> wrote:
> 
>> The previous commit unintentionally removed the code responsible for
>> enabling WoL via MMD3 register 0x8012 BIT5. As a result, Wake-on-LAN
>> (WoL) support for the QCA808X PHY is no longer functional.
>>
>> The WoL (Wake-on-LAN) feature for the QCA808X PHY is enabled via MMD3
>> register 0x8012, BIT5. This implementation is aligned with the approach
>> used in at8031_set_wol().
>>
>> Fixes: e58f30246c35 ("net: phy: at803x: fix the wol setting functions")
>> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>
> 
> If this is a fix, you should target the -net tree instead -net-next :)
> 
> Maxime

OK. I will resend the patch series targeting the -net tree instead.
Thank you for the feedback.