linux-kernel - Re: [PATCH v11 4/8] iio: accel: adxl345: add inactivity feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGalkb42uRQ12Wr0@smile.fi.intel.com>
Date: Thu, 3 Jul 2025 18:45:21 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org,
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
	corbet@....net, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	eraretuya@...il.com
Subject: Re: [PATCH v11 4/8] iio: accel: adxl345: add inactivity feature

On Thu, Jul 03, 2025 at 04:59:50PM +0200, Lothar Rubusch wrote:
> On Thu, Jul 3, 2025 at 4:26 PM Andy Shevchenko
> <andriy.shevchenko@...el.com> wrote:
> > On Wed, Jul 02, 2025 at 11:03:11PM +0000, Lothar Rubusch wrote:

...

> > >  #define ADXL345_REG_TAP_SUPPRESS_MSK BIT(3)
> > >  #define ADXL345_REG_TAP_SUPPRESS     BIT(3)
> > >  #define ADXL345_REG_ACT_AXIS_MSK     GENMASK(6, 4)
> > > +#define ADXL345_REG_INACT_AXIS_MSK   GENMASK(2, 0)
> > > +#define ADXL345_POWER_CTL_INACT_MSK  (ADXL345_POWER_CTL_AUTO_SLEEP | ADXL345_POWER_CTL_LINK)
> > >
> > >  #define ADXL345_TAP_Z_EN             BIT(0)
> > >  #define ADXL345_TAP_Y_EN             BIT(1)
> > >  #define ADXL345_TAP_X_EN             BIT(2)
> > >
> > > +#define ADXL345_INACT_Z_EN           BIT(0)
> > > +#define ADXL345_INACT_Y_EN           BIT(1)
> > > +#define ADXL345_INACT_X_EN           BIT(2)
> > > +#define ADXL345_INACT_XYZ_EN         (ADXL345_INACT_Z_EN | ADXL345_INACT_Y_EN | ADXL345_INACT_X_EN)
> > > +
> > >  #define ADXL345_ACT_Z_EN             BIT(4)
> > >  #define ADXL345_ACT_Y_EN             BIT(5)
> > >  #define ADXL345_ACT_X_EN             BIT(6)
> >
> > Now it's even more mess. I am lost in understanding which bits/masks are from
> > the same offset and which are not.
> >
> 
> I'm sorry for that. I mean, while the above is supposed to make it
> clear where the "values" are coming from, I also could setup something
> like the following which is shorter.
> +#define ADXL345_INACT_XYZ_EN        GENMASK(2,0)
> +#define ADXL345_ACT_XYZ_EN        GENMASK(6,4)
> 
> As I understand you, you'd rather prefer to see the latter one in the kernel?

My personal preference can be found, for example, in
drivers/pinctrl/intel/pinctrl-intel.c. But I'm not insisting to use
_my_ schema. Just find a way how to group them semantically.

-- 
With Best Regards,
Andy Shevchenko