linux-kernel - Re: [PATCH v5 2/3] i2c: tegra: make reset an optional property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507032359.AfHPKWEQ-lkp@intel.com>
Date: Fri, 4 Jul 2025 00:02:12 +0800
From: kernel test robot <lkp@...el.com>
To: Akhil R <akhilrajeev@...dia.com>, andriy.shevchenko@...ux.intel.com,
	andi.shyti@...nel.org, digetx@...il.com, jonathanh@...dia.com,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-tegra@...r.kernel.org, p.zabel@...gutronix.de,
	thierry.reding@...il.com
Cc: oe-kbuild-all@...ts.linux.dev, akhilrajeev@...dia.com,
	conor+dt@...nel.org, devicetree@...r.kernel.org, krzk+dt@...nel.org,
	ldewangan@...dia.com, robh@...nel.org
Subject: Re: [PATCH v5 2/3] i2c: tegra: make reset an optional property

Hi Akhil,

kernel test robot noticed the following build errors:

[auto build test ERROR on tegra/for-next]
[also build test ERROR on andi-shyti/i2c/i2c-host linus/master v6.16-rc4 next-20250703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Akhil-R/i2c-tegra-make-reset-an-optional-property/20250702-214005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
patch link:    https://lore.kernel.org/r/20250702133450.64257-2-akhilrajeev%40nvidia.com
patch subject: [PATCH v5 2/3] i2c: tegra: make reset an optional property
config: sh-randconfig-002-20250703 (https://download.01.org/0day-ci/archive/20250703/202507032359.AfHPKWEQ-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250703/202507032359.AfHPKWEQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507032359.AfHPKWEQ-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/build_bug.h:5,
                    from include/linux/bits.h:22,
                    from include/linux/ioport.h:13,
                    from include/linux/acpi.h:12,
                    from drivers/i2c/busses/i2c-tegra.c:9:
   drivers/i2c/busses/i2c-tegra.c: In function 'tegra_i2c_reset':
>> drivers/i2c/busses/i2c-tegra.c:632:23: error: implicit declaration of function 'acpi_has_method'; did you mean 'acpi_has_watchdog'? [-Wimplicit-function-declaration]
     632 |         if (handle && acpi_has_method(handle, "_RST")) {
         |                       ^~~~~~~~~~~~~~~
   include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
      57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   drivers/i2c/busses/i2c-tegra.c:632:9: note: in expansion of macro 'if'
     632 |         if (handle && acpi_has_method(handle, "_RST")) {
         |         ^~


vim +632 drivers/i2c/busses/i2c-tegra.c

   626	
   627	static int tegra_i2c_reset(struct tegra_i2c_dev *i2c_dev)
   628	{
   629		acpi_handle handle = ACPI_HANDLE(i2c_dev->dev);
   630		int err;
   631	
 > 632		if (handle && acpi_has_method(handle, "_RST")) {
   633			err = acpi_evaluate_object(handle, "_RST", NULL, NULL);
   634			if (ACPI_FAILURE(err))
   635				return -EIO;
   636	
   637			return 0;
   638		}
   639	
   640		if (i2c_dev->rst)
   641			return reset_control_reset(i2c_dev->rst);
   642	
   643		return tegra_i2c_master_reset(i2c_dev);
   644	}
   645	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki