[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e5e8262a-db33-4abd-b31d-fc476dfab0bf@microchip.com>
Date: Thu, 3 Jul 2025 02:49:23 +0000
From: <Balamanikandan.Gunasundar@...rochip.com>
To: <fourier.thomas@...il.com>
CC: <stable@...r.kernel.org>, <miquel.raynal@...tlin.com>, <richard@....at>,
<vigneshr@...com>, <Nicolas.Ferre@...rochip.com>,
<alexandre.belloni@...tlin.com>, <claudiu.beznea@...on.dev>,
<u.kleine-koenig@...libre.com>, <ada@...rsis.com>, <bbrezillon@...nel.org>,
<linux-mtd@...ts.infradead.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mtd: rawnand: atmel: Fix dma_mapping_error() address
Reviewed-by: Balamanikandan Gunasundar
<balamanikandan.gunasundar@...rochip.com>
On 02/07/25 12:15 pm, Thomas Fourier wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> It seems like what was intended is to test if the dma_map of the
> previous line failed but the wrong dma address was passed.
>
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> Signed-off-by: Thomas Fourier <fourier.thomas@...il.com>
> ---
> v1 -> v2:
> - Add stable@...r.kernel.org
> - Fix subject prefix
>
> drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index dedcca87defc..84ab4a83cbd6 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -373,7 +373,7 @@ static int atmel_nand_dma_transfer(struct atmel_nand_controller *nc,
> dma_cookie_t cookie;
>
> buf_dma = dma_map_single(nc->dev, buf, len, dir);
> - if (dma_mapping_error(nc->dev, dev_dma)) {
> + if (dma_mapping_error(nc->dev, buf_dma)) {
> dev_err(nc->dev,
> "Failed to prepare a buffer for DMA access\n");
> goto err;
> --
> 2.43.0
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
Powered by blists - more mailing lists