linux-kernel - Re: [PATCH v5 10/10] drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <737a4487-d474-4adc-b369-2a88792c81c4@intel.com>
Date: Thu, 3 Jul 2025 10:06:41 -0700
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@...el.com>
To: Rodrigo Vivi <rodrigo.vivi@...el.com>, Badal Nilawar
	<badal.nilawar@...el.com>
CC: <intel-xe@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, <anshuman.gupta@...el.com>,
	<alexander.usyskin@...el.com>, <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v5 10/10] drm/xe/xe_late_bind_fw: Select
 INTEL_MEI_LATE_BIND for CI

On 7/2/2025 2:48 PM, Rodrigo Vivi wrote:
> On Wed, Jul 02, 2025 at 10:22:16PM +0530, Badal Nilawar wrote:
>> Do not review
> Why?
>
> Why don't we add this dependency here?

For INTEL_MEI_LATE_BIND to work we also need  INTEL_MEI_GSC, which is 
the config for the mei child device and depends on the config for our 
driver, so a "depends on" tag would go circular.
INTEL_MEI_GSC also has further dependencies, so if we wanted to "select" 
it (instead of marking it with a "depends on") we'd have to select those 
dependencies as well, which doesn't scale well.
This patch only works as-is because our CI config does enable 
INTEL_MEI_GSC with all its dependencies.

For other mei components (e.g. PXP, HDCP) what we did was notify the 
distros that they had to enable the option in their kernel builds if 
they wanted the feature to be enabled, so the idea was to do the same here.

Unless there is a kconfig trick we're missing that would make this work?

Daniele

>
>> Signed-off-by: Badal Nilawar <badal.nilawar@...el.com>
>> ---
>>   drivers/gpu/drm/xe/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>> index f66e6d39e319..ef3f4807b0b3 100644
>> --- a/drivers/gpu/drm/xe/Kconfig
>> +++ b/drivers/gpu/drm/xe/Kconfig
>> @@ -45,6 +45,7 @@ config DRM_XE
>>   	select WANT_DEV_COREDUMP
>>   	select AUXILIARY_BUS
>>   	select HMM_MIRROR
>> +	select INTEL_MEI_LATE_BIND
>>   	help
>>   	  Driver for Intel Xe2 series GPUs and later. Experimental support
>>   	  for Xe series is also available.
>> -- 
>> 2.34.1
>>