lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e5c2ead0-7f8e-44e6-9af7-8addf7b7d016@gmail.com>
Date: Thu, 3 Jul 2025 09:54:02 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Jonathan Corbet <corbet@....net>,
 Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
Cc: Randy Dunlap <rdunlap@...radead.org>, kernel@...labora.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] docs: document linked lists

On 7/3/25 09:52, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@...il.com> writes:
> 
>> On Wed, Jul 02, 2025 at 10:24:47PM +0200, Nicolas Frattaroli wrote:
>>> +In State 2, we've added Grock after the list head::
>>> +
>>> +         .--------------------.
>>> +         v                    |
>>> +    .--------.     .-------.  |
>>> +    | clowns |---->| Grock |--'
>>> +    '--------'     '-------'
>>
>> Looks like the corners are a bit imbalanced (single quotes are taller than
>> dots). What about using plus instead? Like:
>>
>> ---- >8 ----
>> diff --git a/Documentation/core-api/list.rst b/Documentation/core-api/list.rst
>> index b0586056abb04d..bf92f44d7b2d06 100644
>> --- a/Documentation/core-api/list.rst
>> +++ b/Documentation/core-api/list.rst
>> @@ -148,11 +148,11 @@ clarity.
>>   
>>   In State 2, we've added Grock after the list head::
>>   
>> -         .--------------------.
>> +         +--------------------+
>>            v                    |
> 
> One might argue that it looks like a nice curve and should stay as-is.
> 
> This work is welcome and deserves a serious review, this wasn't it.
> 

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ