[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <874ivtkuk9.fsf@trenco.lwn.net>
Date: Thu, 03 Jul 2025 12:17:42 -0600
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, Akira Yokosawa
<akiyks@...il.com>
Subject: Re: [PATCH 7/7] docs: kdoc: pretty up dump_enum()
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:
> Em Tue, 1 Jul 2025 14:57:30 -0600
> Jonathan Corbet <corbet@....net> escreveu:
>
>> self.emit_msg(ln,
>> - f"expecting prototype for enum {self.entry.identifier}. Prototype was for enum {declaration_name} instead")
>> + f"expecting prototype for enum {self.entry.identifier}. "
>> + f"Prototype was for enum {declaration_name} instead")
>
> Even being a big one, my personal preference would be to break the long
> string here, as keeping together is easier for grep, but yeah, I also
> considered breaking it ;-)
Did you mean your preference would be to *not* break it?
There's a non-greppable piece at the break point anyway, so I wasn't
anticipating making life harder for anybody there.
Thanks,
jon
Powered by blists - more mailing lists