linux-kernel - Re: [PATCH v5 3/3] cpufreq: tegra124: Allow building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALHNRZ_jzSGF2xTNMt_giEa4T6r6+qfhp-EubTViqYL7jYf=sw@mail.gmail.com>
Date: Thu, 3 Jul 2025 13:33:08 -0500
From: Aaron Kling <webgeek1234@...il.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Thierry Reding <thierry.reding@...il.com>, 
	Jonathan Hunter <jonathanh@...dia.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v5 3/3] cpufreq: tegra124: Allow building as a module

On Wed, Jul 2, 2025 at 3:12 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 02-07-25, 02:46, Aaron Kling via B4 Relay wrote:
> > +static struct platform_device *platform_device;
>
> Maybe initialize this to an error value...
>
> > +static void __exit tegra_cpufreq_module_exit(void)
> > +{
> > +     if (platform_device && !IS_ERR(platform_device))
>
> ... and then this could be simplified ?
>
> Or use !IS_ERR_OR_NULL .

Latter sounds better to me. I'll queue that up and send a new patchset
in a couple days, pending any further comments.

Aaron